added null check to prevent NullPointerExceptions#873
Merged
Conversation
ikbalkaya
reviewed
Dec 5, 2022
ikbalkaya
reviewed
Dec 5, 2022
Contributor
ikbalkaya
left a comment
ikbalkaya
left a comment
There was a problem hiding this comment.
A comment, but only if you can confirm whether that would be an improvement, otherwise LGTM
ikbalkaya
approved these changes
Dec 6, 2022
Contributor
ikbalkaya
left a comment
ikbalkaya
left a comment
There was a problem hiding this comment.
Approving this as a workaround - as commented, I think we might be covering up another issue with adding this check here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I failed to reproduce NullPointerException reported by an Android AAT customer (corresponding AAT issue here). Based on code investigation, this is the only place this exception could occur.
I see two downsides to this fix:
Given the excessive time spent looking into this, I think it is worth merging this in its current state
Fixes #853