RTN-13c Add spec that channels do not reattach when connection isn't connected#323
Merged
owenpearson merged 1 commit intomainfrom Sep 20, 2021
Merged
RTN-13c Add spec that channels do not reattach when connection isn't connected#323owenpearson merged 1 commit intomainfrom
owenpearson merged 1 commit intomainfrom
Conversation
owenpearson
requested changes
Sep 13, 2021
Member
owenpearson
left a comment
owenpearson
left a comment
There was a problem hiding this comment.
Looks good, just one small thing to change
TheSmartnik
force-pushed
the
RTN-13c
branch
from
6c5bee1 to
4889f74
Compare
ghost
approved these changes
Sep 14, 2021
owenpearson
approved these changes
Sep 20, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As part of
#244