Added DeltaExtras class and Message#delta_extras method. (TM2i)#325
Merged
owenpearson merged 3 commits intomainfrom Oct 4, 2021
Merged
Added DeltaExtras class and Message#delta_extras method. (TM2i)#325owenpearson merged 3 commits intomainfrom
owenpearson merged 3 commits intomainfrom
Conversation
ghost
self-assigned this
ghost
requested a review
from 
TheSmartnik
reviewed
Sep 20, 2021
TheSmartnik
suggested changes
Sep 20, 2021
Contributor
TheSmartnik
left a comment
TheSmartnik
left a comment
There was a problem hiding this comment.
Could you please add unit specs for DeltaExtras and a small method spec for Message?
added 2 commits
September 20, 2021 19:03
Author
Yes, added these tests. |
TheSmartnik
approved these changes
Sep 27, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #273
Added
DeltaExtrasclass andMessage#delta_extras