Merged
Conversation
…d tests. Implemented channel_options as ChannelOptions object instead of Hash.
870445c to
bae93f1
Compare
Previously Channels#get would only accept hash as an argument for options. This commit adds specs for that case and also updates docs
Contributor
Author
|
@lukaszsliwa thanks! So, specs specify that both params and flags are should be added only for ATTACH (RTL4k, RTL4l) that's why I haven't added anything to as_json |
owenpearson
approved these changes
Dec 6, 2021
ghost
suggested changes
Dec 6, 2021
|
RTS3c1 and RTL16a seems to be implemented incorrect. In RTS3c1 it should raise an exception but it does not: ably = Ably::Realtime.new(key: ENV['ABLY_API_KEY'], log_level: :debug, params: { y: '1' })
100.times do |index|
channel = ably.channels.get('channel-123', params: { x: '1' }) # (1)
channel.publish('test', index.to_s)
channel = ably.channels.get('channel-123', params: { x: '2' }) # (2) here it should raise because of RTS3c1 but it does not raise anything
channel.publish('test', index.to_s)
channel = ably.channels.get('channel-123', params: { x: '3' }) # (3)
channel.publish('test', index.to_s)
sleep 10
endWhen index=0 and checkpoint (2) it should raise the exception but it does not. For RTL16a it seems like Action.ATTACHED receives empty params. Screen below: |
Merged
This was
linked to
issues
Feb 23, 2022
Closed
Closed
|
Github does not allow to link more than 10 issues. This PR contains 14 issues, so 4 issues should be closed manually. |
Member
|
#336 (comment) |
…s to rest/channels and realtime/channels.
Contributor
Author
|
@lukaszsliwa regarding your comment to raise an error channel should be in attached state. Here is a spec with exactly your code: 13c3894 |
ghost
approved these changes
Mar 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Resolves