Add support for RSA4b, b1, c, RSA16 (Authentication)#338
Merged
owenpearson merged 2 commits intomainfrom Mar 4, 2022
Merged
Conversation
…tribute and started using current_time when checking expiration and authorize for new token.
ghost
self-assigned this
ghost
marked this pull request as ready for review
TheSmartnik
reviewed
Feb 14, 2022
TheSmartnik
reviewed
Feb 14, 2022
TheSmartnik
reviewed
Feb 14, 2022
Contributor
|
An approval from @TheSmartnik is going to carry much more value than one from me, so I'm going to remove my review request. There is a lot of background context to this change and the spec points referenced are borderline cryptic, so I would prefer to trust in those who are more actively working on this SDK to make the call as to whether this is ready to be merged. |
TheSmartnik
approved these changes
Mar 4, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #268 #281
fromoption) RSA4b, RSA4b1current_token_details