Allowing ConnectionDetails#max_message_size

[ghost]

Allowing max_message_size for Realtime client. Client gets max_message_size from current connection.details. ConnectionDetails attributes are populated when connection is in CONNECTED state.

Added max_message_size to Ably::Rest::Client.

[owenpearson]

LGTM, thanks, although I would prefer to have a spec which mocks the server to respond with a different maxMessageSize and assert that the library sets its own max_message_size accordingly. Do you reckon this would be easy enough to do @lukaszsliwa ?

[ghost]

LGTM, thanks, although I would prefer to have a spec which mocks the server to respond with a different maxMessageSize and assert that the library sets its own max_message_size accordingly. Do you reckon this would be easy enough to do @lukaszsliwa ?

Thanks @owenpearson . I have prepared two more tests. Both for a case, when the server sends Action.CONNECTED and no maxMessageSize is provided.

Here is the example snippet, if the client wants (because of some reason) overwrite the server parameters:

client.connection.once(:connected) do
  connection_details = Ably::Models::ConnectionDetails.new(
    'maxMessageSize' => 1048576 # 1MB
    #...
  )
  client.connection.set_connection_details(connection_details)
  channel.publish('event', 'x' * 1048575)
end