[ECO-4058][Protocol-2] Feature/integration protocol 2 tests#426
Merged
sacOO7 merged 9 commits intofeature/integration-protocol-2from Jul 5, 2024
Merged
Conversation
Made sure client is connected before doing further operations
added recovery_key specific tests
removed unncessary test that checks for invalid server message using connection serial
ttypic
reviewed
Jul 5, 2024
ttypic
approved these changes
Jul 5, 2024
Contributor
ttypic
left a comment
ttypic
left a comment
There was a problem hiding this comment.
Other than comments for skipped test looks great! Thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Making sure connection state is connected before attaching channelbecause if reduces flakiness of the tests