fix: update BetaAsyncAbstractMemoryTool docstring to use async example#1312
Open
yuribodo wants to merge 1 commit intoanthropics:mainfrom
Open
fix: update BetaAsyncAbstractMemoryTool docstring to use async example#1312yuribodo wants to merge 1 commit intoanthropics:mainfrom
yuribodo wants to merge 1 commit intoanthropics:mainfrom
Conversation
The docstring example was copy-pasted from the sync BetaAbstractMemoryTool without being updated for async usage. Following it verbatim would raise TypeError at instantiation time. Changes: - Use BetaAsyncAbstractMemoryTool as the base class - Add async/await to method definitions - Replace Anthropic() with AsyncAnthropic() - Wrap usage in async def main() / asyncio.run(main()) Fixes anthropics#1290
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
BetaAsyncAbstractMemoryTooldocstring example was copy-pasted from the synchronousBetaAbstractMemoryToolwithout being updated for async usage. Following the example verbatim raisesTypeErrorat instantiation time.Changes
BetaAsyncAbstractMemoryToolas the base class (wasBetaAbstractMemoryTool)async defto method definitions (wasdef)Anthropic()withAsyncAnthropic()async def main()/asyncio.run(main())Before (broken)
After (fixed)
Fixes #1290