[BEAM-1343] Fix HDFSFileSource’s split size estimate#1867
Closed
igorbernstein2 wants to merge 1 commit intoapache:masterfrom
Closed
[BEAM-1343] Fix HDFSFileSource’s split size estimate#1867igorbernstein2 wants to merge 1 commit intoapache:masterfrom
igorbernstein2 wants to merge 1 commit intoapache:masterfrom
Conversation
|
Refer to this link for build results (access rights to CI server needed): |
Member
|
R: @jkff |
Contributor
|
LGTM |
Contributor
|
(Sorry, I should have seen this and reviewed it -- I reviewed the DataflowJavaSDK version.) Thanks @igorbernstein2 for porting it forward. I really appreciate it. Merging now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a port of this fix:
GoogleCloudPlatform/DataflowJavaSDK#534
HDFSFileSource incorrectly calculates estimated byte size. The source can represent either a top level source or a split from splitIntoBundles. However, getEstimatedSizeBytes always calculates the size of the entire top level source.
This PR detects if the source represents a split and returns its length.