UI: Fix userdata and load balancer selection#10016
Merged
DaanHoogland merged 2 commits intoapache:4.20from Dec 4, 2024
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.20 #10016 +/- ##
============================================
+ Coverage 15.80% 15.96% +0.15%
- Complexity 12586 12737 +151
============================================
Files 5627 5627
Lines 492344 492433 +89
Branches 59694 59711 +17
============================================
+ Hits 77829 78604 +775
+ Misses 405992 405156 -836
- Partials 8523 8673 +150
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Contributor
|
@sureshanaparti a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
Contributor
|
I am merging forward 4.19 on 4.20 and will merge this as soon as the conflicts are taken care of. |
DaanHoogland
added a commit
that referenced
this pull request
Dec 4, 2024
* 4.20: UI: Fix userdata and load balancer selection (#10016) Prevent password updates for SAML and LDAP users (#9999) cloudstack-migrate-databases: sql AND added (#10033) engine/schema: move SQLs to 4.20.0 to 4.20.1 upgrade (#10018) Remove user from project before deletion (#10008) Simplify validation for creating volume templates via UI (#9828)
This was referenced Dec 4, 2024
dhslove
pushed a commit
to ablecloud-team/ablestack-cloud
that referenced
this pull request
Dec 12, 2024
dhslove
pushed a commit
to ablecloud-team/ablestack-cloud
that referenced
this pull request
Dec 12, 2024
* 4.20: UI: Fix userdata and load balancer selection (apache#10016) Prevent password updates for SAML and LDAP users (apache#9999) cloudstack-migrate-databases: sql AND added (apache#10033) engine/schema: move SQLs to 4.20.0 to 4.20.1 upgrade (apache#10018) Remove user from project before deletion (apache#10008) Simplify validation for creating volume templates via UI (apache#9828)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently, in the VM deployment wizard, when the user tries to select a userdata by clicking on its row (outside the radio button), the userdata is not selected. This behavior also occurs for load balancer selection in the autoscale group creation form.
Additionally, whenever the
listUserDataAPI response doesn't contain theparamsattribute, the following exception is thrown in the browser's console:This PR addresses these issues by enabling users to select the VM's userdata and the autoscale group's load balancer by clicking on the corresponding resource table rows. Furthermore, the UI exception is now properly handled.
Fixes #9990 and fixes #9991
Types of changes
Feature/Enhancement Scale or Bug Severity
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?