Fix to create instances with smaller templates (< 1 GB) on PowerFlex/ScaleIO storage by sureshanaparti · Pull Request #11211 · apache/cloudstack

sureshanaparti · 2025-07-16T04:24:57Z

Description

This PR allows create instances with smaller templates (< 1 GB) on PowerFlex/ScaleIO storage (it's regression after #9008).

Fixes #10981

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
build/CI
test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

Deployed instance using the template (http://dl.openvm.eu/cloudstack/macchinina/x86_64/macchinina-kvm.qcow2.bz2) on PowerFlex storage.

How did you try to break this feature and the system with this change?

sureshanaparti · 2025-07-16T04:30:20Z

@blueorangutan package

blueorangutan · 2025-07-16T04:32:04Z

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

codecov · 2025-07-16T04:32:32Z

Codecov Report

Attention: Patch coverage is 40.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 16.15%. Comparing base (9688cbb) to head (5976ec0).
Report is 6 commits behind head on 4.20.

Files with missing lines	Patch %	Lines
...atastore/driver/ScaleIOPrimaryDataStoreDriver.java	50.00%	4 Missing ⚠️
...hypervisor/kvm/storage/StorPoolStorageAdaptor.java	0.00%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff            @@
##               4.20   #11211   +/-   ##
=========================================
  Coverage     16.15%   16.15%           
  Complexity    13274    13274           
=========================================
  Files          5656     5656           
  Lines        497728   497793   +65     
  Branches      60360    60367    +7     
=========================================
+ Hits          80420    80442   +22     
- Misses       408357   408396   +39     
- Partials       8951     8955    +4

Flag	Coverage Δ
uitests	`4.00% <ø> (ø)`
unittests	`17.01% <40.00%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

…ScaleIO storage

blueorangutan · 2025-07-16T05:45:58Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14200

harikrishna-patnala

code LGTM

DaanHoogland

clgtm, but includes a change in the storpool adaptor. @slavkap can you have a look?

sureshanaparti · 2025-07-16T06:53:46Z

clgtm, but includes a change in the storpool adaptor. @slavkap can you have a look?

@DaanHoogland I noticed an NPE in storpool adaptor, check the log in the issue #10981. cc @slavkap

slavkap

code LGTM
Thanks, @sureshanaparti, I have this fix in another PR #9478, but it will be better for this to get in an earlier release

DaanHoogland

clgtm

sureshanaparti · 2025-07-16T10:42:47Z

@blueorangutan test

blueorangutan · 2025-07-16T10:44:05Z

@sureshanaparti a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

weizhouapache

code lgtm

@sureshanaparti
If volume size is smaller than 1GB, ACS allocates 8GB on powerflex, right ?

.../main/java/org/apache/cloudstack/storage/datastore/driver/ScaleIOPrimaryDataStoreDriver.java

blueorangutan · 2025-07-17T03:41:46Z

[SF] Trillian test result (tid-13799)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 57765 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11211-t13799-kvm-ol8.zip
Smoke tests completed. 141 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

sureshanaparti · 2025-07-17T03:56:08Z

code lgtm

@sureshanaparti If volume size is smaller than 1GB, ACS allocates 8GB on powerflex, right ?

correct @weizhouapache

sureshanaparti · 2025-07-17T05:18:29Z

@blueorangutan package

blueorangutan · 2025-07-17T05:20:04Z

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-07-17T07:01:31Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14225

vladimirpetrov

LGTM, tested with Ubuntu 18, Debian 9 and macchinina templates.

…ScaleIO storage (apache#11211) * Fix to create instances with smaller templates (< 1 GB) on PowerFlex/ScaleIO storage * code improvements

boring-cyborg bot added component:primary-storage component:storage labels Jul 16, 2025

sureshanaparti added the component:powerflex label Jul 16, 2025

Fix to create instances with smaller templates (< 1 GB) on PowerFlex/…

6ceac85

…ScaleIO storage

sureshanaparti force-pushed the powerflex_smaller_templates_fix branch from 321564c to 6ceac85 Compare July 16, 2025 04:54

sureshanaparti changed the title ~~Fix to create instances with smaller templates (< 8 GB) on PowerFlex/ScaleIO storage~~ Fix to create instances with smaller templates (< 1 GB) on PowerFlex/ScaleIO storage Jul 16, 2025

sureshanaparti requested review from DaanHoogland, vishesh92 and vladimirpetrov July 16, 2025 04:56

sureshanaparti requested a review from harikrishna-patnala July 16, 2025 06:42

harikrishna-patnala approved these changes Jul 16, 2025

View reviewed changes

sureshanaparti linked an issue Jul 16, 2025 that may be closed by this pull request

Unable to create instance on PowerFlex storage (with smaller templates) #10981

Closed

DaanHoogland requested a review from slavkap July 16, 2025 06:48

DaanHoogland reviewed Jul 16, 2025

View reviewed changes

slavkap approved these changes Jul 16, 2025

View reviewed changes

DaanHoogland approved these changes Jul 16, 2025

View reviewed changes

sureshanaparti added the status:needs-testing label Jul 16, 2025

sureshanaparti assigned vladimirpetrov Jul 16, 2025

weizhouapache approved these changes Jul 17, 2025

View reviewed changes

weizhouapache reviewed Jul 17, 2025

View reviewed changes

.../main/java/org/apache/cloudstack/storage/datastore/driver/ScaleIOPrimaryDataStoreDriver.java Outdated Show resolved Hide resolved

code improvements

5976ec0

vladimirpetrov approved these changes Jul 22, 2025

View reviewed changes

sureshanaparti removed the status:needs-testing label Jul 22, 2025

sureshanaparti added this to the 4.20.2 milestone Jul 22, 2025

sureshanaparti merged commit d5f6b7c into apache:4.20 Jul 22, 2025
25 of 26 checks passed

sureshanaparti mentioned this pull request Jul 22, 2025

Unable to create instance on PowerFlex storage (with smaller templates) #10981

Closed

DaanHoogland deleted the powerflex_smaller_templates_fix branch July 22, 2025 16:55

Conversation

sureshanaparti commented Jul 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Uh oh!

sureshanaparti commented Jul 16, 2025

Uh oh!

blueorangutan commented Jul 16, 2025

Uh oh!

codecov bot commented Jul 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

blueorangutan commented Jul 16, 2025

Uh oh!

harikrishna-patnala left a comment

Choose a reason for hiding this comment

Uh oh!

DaanHoogland left a comment

Choose a reason for hiding this comment

Uh oh!

sureshanaparti commented Jul 16, 2025

Uh oh!

slavkap left a comment

Choose a reason for hiding this comment

Uh oh!

DaanHoogland left a comment

Choose a reason for hiding this comment

Uh oh!

sureshanaparti commented Jul 16, 2025

Uh oh!

blueorangutan commented Jul 16, 2025

Uh oh!

weizhouapache left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

blueorangutan commented Jul 17, 2025

Uh oh!

sureshanaparti commented Jul 17, 2025

Uh oh!

sureshanaparti commented Jul 17, 2025

Uh oh!

blueorangutan commented Jul 17, 2025

Uh oh!

blueorangutan commented Jul 17, 2025

Uh oh!

vladimirpetrov left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

sureshanaparti commented Jul 16, 2025 •

edited

Loading

codecov bot commented Jul 16, 2025 •

edited

Loading