Skip to content

CKS: fix resource limitation check on cpu when scale cks cluster#12379

Merged
DaanHoogland merged 1 commit intoapache:4.22from
weizhouapache:4.22-cks-scale-cpu-check
Jan 21, 2026
Merged

CKS: fix resource limitation check on cpu when scale cks cluster#12379
DaanHoogland merged 1 commit intoapache:4.22from
weizhouapache:4.22-cks-scale-cpu-check

Conversation

@weizhouapache
Copy link
Member

@weizhouapache weizhouapache commented Jan 6, 2026

Description

This PR fixes the smoke test failure

   test_03_deploy_and_scale_kubernetes_cluster | `Failure` | 44.28 | test_kubernetes_clusters.py

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@weizhouapache weizhouapache added this to the 4.22.1 milestone Jan 6, 2026
@weizhouapache
Copy link
Member Author

@blueorangutan package

@blueorangutan
Copy link

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@codecov
Copy link

codecov bot commented Jan 6, 2026

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 17.59%. Comparing base (2d4b7ba) to head (d1bdbde).
⚠️ Report is 29 commits behind head on 4.22.

Files with missing lines Patch % Lines
...bernetes/cluster/KubernetesClusterManagerImpl.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               4.22   #12379      +/-   ##
============================================
- Coverage     17.59%   17.59%   -0.01%     
+ Complexity    15596    15595       -1     
============================================
  Files          5910     5910              
  Lines        529634   529633       -1     
  Branches      64714    64714              
============================================
- Hits          93176    93172       -4     
- Misses       425968   425969       +1     
- Partials      10490    10492       +2     
Flag Coverage Δ
uitests 3.57% <ø> (ø)
unittests 18.66% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✖️ debian ✔️ suse15. SL-JID 16273

Copy link
Contributor

@shwstppr shwstppr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

@weizhouapache
Copy link
Member Author

@blueorangutan package

@blueorangutan
Copy link

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 16278

@weizhouapache
Copy link
Member Author

@blueorangutan test

@blueorangutan
Copy link

@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

@blueorangutan
Copy link

[SF] Trillian test result (tid-15130)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 54098 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr12379-t15130-kvm-ol8.zip
Smoke tests completed. 148 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_01_vpn_usage Error 1.10 test_usage.py

@weizhouapache weizhouapache marked this pull request as ready for review January 14, 2026 09:06
@weizhouapache
Copy link
Member Author

this is regression of #12167

@Pearl1594 @DaanHoogland
does this look good to you ?

@DaanHoogland
Copy link
Contributor

this is regression of #12167

@Pearl1594 @DaanHoogland does this look good to you ?

yes, wasn’t a similar change done recently?

@weizhouapache
Copy link
Member Author

this is regression of #12167
@Pearl1594 @DaanHoogland does this look good to you ?

yes, wasn’t a similar change done recently?

I do not remember it, sorry @DaanHoogland

@DaanHoogland
Copy link
Contributor

does it still need testing?

@DaanHoogland DaanHoogland merged commit 036489b into apache:4.22 Jan 21, 2026
40 of 62 checks passed
@DaanHoogland DaanHoogland deleted the 4.22-cks-scale-cpu-check branch January 21, 2026 08:59
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Mar 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

5 participants