kvm: Set amount of queues for Virtio SCSI driver to vCPU of Instance

[wido]

Description

The additional queues can enhance the performance of the VirtIO SCSI disk
and it is recommended to set this to the amount of vCPUs a Instance is assigned.

The optional queues attribute specifies the number of queues for the
controller. For best performance, it's recommended to specify a value matching
the number of vCPUs. Since 1.0.5 (QEMU and KVM only)

Source: https://libvirt.org/formatdomain.html#elementsVirtio

Types of changes

• Enhancement (improves an existing feature and functionality)

Screenshots (if appropriate):

How Has This Been Tested?

Tested on local Cloud and Unit Tests have been extended.

[ustcweizhou]

good
lgtm

[nathanejohnson]

lgtm

[nathanejohnson]

lgtm

[GabrielBrascher]

@blueorangutan package

[blueorangutan]

@GabrielBrascher a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GabrielBrascher]

Code LGTM

[blueorangutan]

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2503

[GabrielBrascher]

@wido Travis failures are false positives. Apart from that, all checks and the packaging are good.
@rhtyd @DaanHoogland @dhlaluku this one is ready for testing; thanks guys!

[yadvr]

@blueorangutan package

[blueorangutan]

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2504

[anuragaw]

@blueorangutan test

[blueorangutan]

@anuragaw a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[anuragaw]

Curious question - does this put constraints on the version of libvirtd supported going forward or the optional parameter will be ignored by older versions.

[kiwiflyer]

@anuragaw The queues feature was introduced into libvirt back in 2013, so it's been available for a while. We introduced the virtio-scsi feature set about a year ago and this PR from Wido adds a nice additional feature to that.

https://www.redhat.com/archives/libvir-list/2013-April/msg00021.html

[anuragaw]

Thanks for the clarification @kiwiflyer !

[blueorangutan]

Trillian test result (tid-3274)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 25770 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3101-t3274-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_multipleips_per_nic.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Smoke tests completed. 68 look OK, 2 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_nic_secondaryip_add_remove	Error	42.46	test_multipleips_per_nic.py
test_04_rvpc_network_garbage_collector_nics	Failure	510.34	test_vpc_redundant.py

[anuragaw]

Trillian test results seem fine.

[GabrielBrascher]

Merging this based on Trillian test results, manual tests, and that we have 4 LGTMs.
Travis failures are not related to this PR (the same failure for multiple open PRs, we have to check on it).