Remove rolling-maintenance service from debian rules by nvazquez · Pull Request #3984 · apache/cloudstack

nvazquez · 2020-03-23T12:56:57Z

Description

The cloudstack-rolling-maintenance service fails on ubuntu while packaging.

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)

Screenshots (if appropriate):

How Has This Been Tested?

~/cloudstack/packaging# ./build-deb.sh

nvazquez · 2020-03-23T12:57:09Z

@blueorangutan package

blueorangutan · 2020-03-23T12:58:07Z

@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

DaanHoogland · 2020-03-23T13:19:13Z

@nvazquez does this mean we will not support rolling maintenance on ubuntu? (do update needed!)

blueorangutan · 2020-03-23T13:25:17Z

Packaging result: ✖centos6 ✔centos7 ✔debian. JID-1077

GabrielBrascher

I had the same issue when building packages on Ubuntu 18.04. Removing -pcloudstack-rolling-maintenance@ solved the issues.

Error:

dh_systemd_enable -pcloudstack-management -pcloudstack-agent -pcloudstack-usage -pcloudstack-rolling-maintenance@
dh_systemd_enable: Requested unknown package cloudstack-rolling-maintenance@ via -p/--package, expected one of: cloudstack-common cloudstack-management cloudstack-agent cloudstack-usage cloudstack-docs cloudstack-marvin cloudstack-integration-tests
dh_systemd_enable: unknown option or error during option parsing; aborting
debian/rules:144: recipe for target 'override_dh_systemd_enable' failed
make[1]: *** [override_dh_systemd_enable] Error 255

nvazquez · 2020-03-25T12:33:04Z

@blueorangutan package

blueorangutan · 2020-03-25T12:34:16Z

@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2020-03-25T13:00:18Z

Packaging result: ✖centos6 ✔centos7 ✔debian. JID-1086

andrijapanicsb · 2020-03-25T15:24:36Z

@nvazquez are we good here?
@weizhouapache can you review also please/LGTM it?

andrijapanicsb · 2020-03-25T15:25:20Z

anybody tested on Ubuntu 16 (any need to do so)?

weizhouapache · 2020-03-25T16:25:40Z

@nvazquez are we good here?
@weizhouapache can you review also please/LGTM it?

is this ready for review/approve ?

nvazquez · 2020-03-25T16:29:59Z

Yes, ready for review. I haven't updated as was having failures non related to the PR to build an ubuntu18 environment. Would be good to test in ubuntu 16 as well

nvazquez · 2020-03-25T18:07:40Z

Update: finally built environment with ubuntu 18 KVM hosts and verified the rolling maintenance service works as expected

andrijapanicsb

LGTM
(Ubuntu 18.04 - also the API was briefly tested to verify the rolling maintenance was not broken)

nvazquez · 2020-03-25T18:25:22Z

The rolling maintenance service is included as part of the cloudstack-agent package, it was mistakinly added as a package to enable by the dh_system_enable call. The fix is simply removing the call to enable the not existing package from the rules script

weizhouapache

I have tested it on ubuntu 18.04, it works.

Based on @nvazquez 's test with the rolling maintenance, it is good.

blueorangutan · 2020-03-26T09:54:20Z

@andrijapanicsb a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2020-03-26T18:47:37Z

Trillian test result (tid-1314)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 28237 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3984-t1314-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_global_settings.py
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermittent failure detected: /marvin/tests/smoke/test_host_maintenance.py
Smoke tests completed. 74 look OK, 3 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_UpdateConfigParamWithScope	`Error`	0.06	test_global_settings.py
test_02_vpc_privategw_static_routes	`Failure`	133.54	test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanup	`Failure`	142.41	test_privategw_acl.py
test_04_rvpc_privategw_static_routes	`Failure`	203.34	test_privategw_acl.py
test_02_cancel_host_maintenace_with_migration_jobs	`Failure`	165.43	test_host_maintenance.py

nvazquez · 2020-03-26T19:41:15Z

@blueorangutan test

blueorangutan · 2020-03-26T19:42:21Z

@nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2020-03-27T03:53:13Z

Trillian test result (tid-1325)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 27895 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3984-t1325-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_global_settings.py
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermittent failure detected: /marvin/tests/smoke/test_host_maintenance.py
Smoke tests completed. 74 look OK, 3 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_UpdateConfigParamWithScope	`Error`	0.11	test_global_settings.py
test_02_vpc_privategw_static_routes	`Failure`	125.98	test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanup	`Failure`	128.01	test_privategw_acl.py
test_04_rvpc_privategw_static_routes	`Failure`	190.47	test_privategw_acl.py
test_02_cancel_host_maintenace_with_migration_jobs	`Failure`	171.13	test_host_maintenance.py

nvazquez · 2020-03-28T04:54:04Z

@blueorangutan package

blueorangutan · 2020-03-28T04:54:28Z

@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2020-03-28T05:21:10Z

Packaging result: ✔centos7 ✔debian. JID-1100

nvazquez · 2020-03-28T05:22:38Z

@blueorangutan test

blueorangutan · 2020-03-28T05:23:27Z

@nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

andrijapanicsb · 2020-03-30T09:38:41Z

@nvazquez this needs some love, asap, please

andrijapanicsb · 2020-04-03T18:39:58Z

@blueorangutan package

blueorangutan · 2020-04-03T18:41:09Z

@andrijapanicsb a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2020-04-03T19:22:00Z

Packaging result: ✔centos7 ✔debian. JID-1124

andrijapanicsb · 2020-04-03T19:24:34Z

@blueorangutan test

blueorangutan · 2020-04-03T19:25:10Z

@andrijapanicsb a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2020-04-04T08:45:00Z

Trillian test result (tid-1356)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 45907 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3984-t1356-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Smoke tests completed. 83 look OK, 0 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File

andrijapanicsb · 2020-04-04T12:09:11Z

Finally...
Merging based on 3 x LGTMs/Approvals, manual and automated regression tests.

Remove rolling-maintenance service from debian rules

34dfcf5

svenvogel added the type:bug label Mar 23, 2020

DaanHoogland added this to the 4.14.0.0 milestone Mar 24, 2020

GabrielBrascher approved these changes Mar 25, 2020

View reviewed changes

GabrielBrascher self-requested a review March 25, 2020 05:51

andrijapanicsb requested review from weizhouapache and wido March 25, 2020 15:24

nvazquez marked this pull request as ready for review March 25, 2020 18:07

DaanHoogland closed this Mar 25, 2020

DaanHoogland reopened this Mar 25, 2020

andrijapanicsb self-requested a review March 25, 2020 18:15

andrijapanicsb approved these changes Mar 25, 2020

View reviewed changes

GabrielBrascher approved these changes Mar 25, 2020

View reviewed changes

weizhouapache approved these changes Mar 25, 2020

View reviewed changes

apache deleted a comment from blueorangutan Mar 26, 2020

apache deleted a comment from andrijapanicsb Mar 26, 2020

apache deleted a comment from blueorangutan Mar 26, 2020

DaanHoogland closed this Mar 26, 2020

DaanHoogland reopened this Mar 26, 2020

svenvogel added the component:packaging label Mar 26, 2020

apache deleted a comment from blueorangutan Mar 28, 2020

andrijapanicsb mentioned this pull request Mar 30, 2020

Add support for zulu-11 in cloudstack 4.14 #3988

Merged

5 tasks

apache deleted a comment from blueorangutan Apr 4, 2020

andrijapanicsb merged commit 0c4bd53 into apache:master Apr 4, 2020

nvazquez deleted the fixservice branch April 6, 2020 14:32

Conversation

nvazquez commented Mar 23, 2020 • edited by DaanHoogland Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Types of changes

Screenshots (if appropriate):

How Has This Been Tested?

Uh oh!

nvazquez commented Mar 23, 2020

Uh oh!

blueorangutan commented Mar 23, 2020

Uh oh!

DaanHoogland commented Mar 23, 2020

Uh oh!

blueorangutan commented Mar 23, 2020

Uh oh!

GabrielBrascher left a comment

Choose a reason for hiding this comment

Uh oh!

nvazquez commented Mar 25, 2020

Uh oh!

blueorangutan commented Mar 25, 2020

Uh oh!

blueorangutan commented Mar 25, 2020

Uh oh!

andrijapanicsb commented Mar 25, 2020

Uh oh!

andrijapanicsb commented Mar 25, 2020

Uh oh!

weizhouapache commented Mar 25, 2020

Uh oh!

nvazquez commented Mar 25, 2020

Uh oh!

nvazquez commented Mar 25, 2020

Uh oh!

andrijapanicsb left a comment

Choose a reason for hiding this comment

Uh oh!

nvazquez commented Mar 25, 2020

Uh oh!

weizhouapache left a comment

Choose a reason for hiding this comment

Uh oh!

blueorangutan commented Mar 26, 2020

Uh oh!

blueorangutan commented Mar 26, 2020

Uh oh!

nvazquez commented Mar 26, 2020

Uh oh!

blueorangutan commented Mar 26, 2020

Uh oh!

blueorangutan commented Mar 27, 2020

Uh oh!

nvazquez commented Mar 28, 2020

Uh oh!

blueorangutan commented Mar 28, 2020

Uh oh!

blueorangutan commented Mar 28, 2020

Uh oh!

nvazquez commented Mar 28, 2020

Uh oh!

blueorangutan commented Mar 28, 2020

Uh oh!

andrijapanicsb commented Mar 30, 2020

Uh oh!

andrijapanicsb commented Apr 3, 2020

Uh oh!

blueorangutan commented Apr 3, 2020

Uh oh!

blueorangutan commented Apr 3, 2020

Uh oh!

andrijapanicsb commented Apr 3, 2020

Uh oh!

blueorangutan commented Apr 3, 2020

Uh oh!

blueorangutan commented Apr 4, 2020

Uh oh!

andrijapanicsb commented Apr 4, 2020

Uh oh!

Reviewers

nvazquez commented Mar 23, 2020 •

edited by DaanHoogland

Loading