Boot into hardware setup menu on Vmware by DaanHoogland · Pull Request #4021 · apache/cloudstack

DaanHoogland · 2020-04-07T09:19:06Z

Description

allow VMs to be started into BIOS on Vmware. This is implemented in the reboot, start and deploy APIs for user VMs.

Related Primate PR: apache/cloudstack-primate#313

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)

Screenshots (if appropriate):

A primate PR has been created with number 313

How Has This Been Tested?

this has been manually verified by means of API/old-UI/primate and checking if the boot menu would then be visible or not depending on the flag passed.

svenvogel · 2020-04-23T12:52:50Z

@DaanHoogland do you think it could be used to extend it for KVM?

DaanHoogland · 2020-04-23T13:43:41Z

bootintobios does not make sense for KVM as you can edit the xml for setup @svenvogel. I have not looked into that, yet. Same is claimed for xen btw. It might make sense for some of the smaller hypervisors.

blueorangutan · 2020-06-04T08:10:32Z

Packaging result: ✔centos7 ✔debian. JID-1294

yadvr · 2020-06-04T23:14:54Z

@blueorangutan test centos7 vmware-67u3

blueorangutan · 2020-06-04T23:15:36Z

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests

blueorangutan · 2020-06-05T15:04:17Z

Trillian test result (tid-1626)
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 55070 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4021-t1626-vmware-67u3.zip
Intermittent failure detected: /marvin/tests/smoke/test_ssvm.py
Smoke tests completed. 82 look OK, 1 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_07_reboot_ssvm	`Failure`	42.20	test_ssvm.py

borisstoyanov

LGTM

UI implementation for apache/cloudstack#4021 Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com> Co-authored-by: Daan Hoogland <dahn@onecht.net> Co-authored-by: Abhishek Kumar <abhishek.mrt22@gmail.com> Co-authored-by: Rohit Yadav <rohit.yadav@shapeblue.com>

andrijapanicsb · 2020-06-22T11:41:18Z

server/src/main/java/com/cloud/vm/UserVmManagerImpl.java

-        UserVm userVm = rebootVirtualMachine(CallContext.current().getCallingUserId(), vmId);
+        Boolean enterSetup = cmd.getBootIntoSetup();
+        if (enterSetup != null && !HypervisorType.VMware.equals(vmInstance.getHypervisorType())) {
+            throw new InvalidParameterValueException("booting into a hardware setup menu does not make sense on " + vmInstance.getHypervisorType());


I don't like this message, missing capital "B" and in general I don't like it... can we reword it to "...not supported for ...." or similar?

ah, yes we can but a new re-word PR is needed.

yadvr · 2020-07-14T08:48:20Z

This or any of the VMware related PRs may have introduced some regression due to consistently failing test test_07_reboot_ssvm :( let's fix that soon irrespective of what/who caused this cc @DaanHoogland

UI implementation for apache/cloudstack#4021 Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com> Co-authored-by: Daan Hoogland <dahn@onecht.net> Co-authored-by: Abhishek Kumar <abhishek.mrt22@gmail.com> Co-authored-by: Rohit Yadav <rohit.yadav@shapeblue.com>

UI implementation for #4021 Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com> Co-authored-by: Daan Hoogland <dahn@onecht.net> Co-authored-by: Abhishek Kumar <abhishek.mrt22@gmail.com> Co-authored-by: Rohit Yadav <rohit.yadav@shapeblue.com>

DaanHoogland mentioned this pull request Apr 7, 2020

UEFI fixes and comments addressed #3983

Closed

5 tasks

DaanHoogland force-pushed the bootIntoBios branch from 982edf0 to ab510a3 Compare April 7, 2020 13:00

apache deleted a comment from blueorangutan Apr 7, 2020

DaanHoogland force-pushed the bootIntoBios branch 2 times, most recently from 7b4f5c9 to 8f68612 Compare April 7, 2020 15:08

apache deleted a comment from blueorangutan Apr 7, 2020

DaanHoogland force-pushed the bootIntoBios branch 2 times, most recently from 447a96c to 7e333a2 Compare April 8, 2020 12:40

apache deleted a comment from blueorangutan Apr 10, 2020

DaanHoogland force-pushed the bootIntoBios branch from b785e0b to af483ca Compare April 15, 2020 10:59

apache deleted a comment from blueorangutan Apr 17, 2020

apache deleted a comment from blueorangutan Apr 20, 2020

apache deleted a comment from blueorangutan Apr 21, 2020

apache deleted a comment from blueorangutan Apr 22, 2020

apache deleted a comment from blueorangutan Apr 23, 2020

DaanHoogland and others added 17 commits June 4, 2020 07:35

more trace

4786e33

tracerest

5f4301e

enable BIOS setup only on vmware

fbc674b

log and passthrough param on startVM

d6354bb

barf if bootintobios on non-vmware

d3b5304

import

6982472

silly unmnecessary npe

a6e81d7

trace parameter adding

a596cfe

keep result for next pass

d42e7d4

boot into setup (not necessarily BIOS)

1229e05

readability comments aplied

b4d97dd

don't reboot if setup requested but not set

5325bc3

inject implementer

357dccd

no name in bean

ba9e853

further modularisation

5cb7a2b

nested virtualisation flags available in unit tests and prod

448cd2e

log name not nics

69db80a

DaanHoogland force-pushed the bootIntoBios branch from 734535c to 69db80a Compare June 4, 2020 07:37

borisstoyanov approved these changes Jun 11, 2020

View reviewed changes

DaanHoogland merged commit 0795cd4 into apache:master Jun 11, 2020

DaanHoogland deleted the bootIntoBios branch June 11, 2020 11:47

andrijapanicsb reviewed Jun 22, 2020

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Boot into hardware setup menu on Vmware#4021

Boot into hardware setup menu on Vmware#4021
DaanHoogland merged 33 commits intoapache:masterfrom
shapeblue:bootIntoBios

DaanHoogland commented Apr 7, 2020 •

edited by yadvr

Loading

Uh oh!

svenvogel commented Apr 23, 2020

Uh oh!

DaanHoogland commented Apr 23, 2020 •

edited

Loading

Uh oh!

blueorangutan commented Jun 4, 2020

Uh oh!

yadvr commented Jun 4, 2020

Uh oh!

blueorangutan commented Jun 4, 2020

Uh oh!

blueorangutan commented Jun 5, 2020

Uh oh!

borisstoyanov left a comment

Uh oh!

andrijapanicsb Jun 22, 2020

Uh oh!

DaanHoogland Jun 22, 2020

Uh oh!

yadvr commented Jul 14, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Conversation

DaanHoogland commented Apr 7, 2020 • edited by yadvr Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Types of changes

Screenshots (if appropriate):

How Has This Been Tested?

Uh oh!

svenvogel commented Apr 23, 2020

Uh oh!

DaanHoogland commented Apr 23, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

blueorangutan commented Jun 4, 2020

Uh oh!

yadvr commented Jun 4, 2020

Uh oh!

blueorangutan commented Jun 4, 2020

Uh oh!

blueorangutan commented Jun 5, 2020

Uh oh!

borisstoyanov left a comment

Choose a reason for hiding this comment

Uh oh!

andrijapanicsb Jun 22, 2020

Choose a reason for hiding this comment

Uh oh!

DaanHoogland Jun 22, 2020

Choose a reason for hiding this comment

Uh oh!

yadvr commented Jul 14, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

DaanHoogland commented Apr 7, 2020 •

edited by yadvr

Loading

DaanHoogland commented Apr 23, 2020 •

edited

Loading