Remove use of blacklist/whitelist terms by PaulAngus · Pull Request #4135 · apache/cloudstack

PaulAngus · 2020-06-08T09:04:09Z

Description

This PR removes the terms blacklist and whitelist in favour of allow list and deny list.

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)

Screenshots (if appropriate):

How Has This Been Tested?

PaulAngus · 2020-06-08T09:04:39Z

@blueorangutan package

blueorangutan · 2020-06-08T09:05:51Z

@PaulAngus a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

DaanHoogland · 2020-06-08T09:11:48Z

api/src/main/java/org/apache/cloudstack/query/QueryService.java

-    static final ConfigKey<String> UserVMBlacklistedDetails = new ConfigKey<String>("Advanced", String.class,
-            "user.vm.blacklisted.details", "rootdisksize, cpuOvercommitRatio, memoryOvercommitRatio, Message.ReservedCapacityFreed.Flag",
+    static final ConfigKey<String> UserVMDenyListedDetails = new ConfigKey<String>("Advanced", String.class,
+            "user.vm.DenyListed.details", "rootdisksize, cpuOvercommitRatio, memoryOvercommitRatio, Message.ReservedCapacityFreed.Flag",


not sure if this is an issue but naming convention fro settings is all lower case.

I've fixed incorrect case change - sloppy C&P

blueorangutan · 2020-06-08T09:16:19Z

Packaging result: ✖centos7 ✖debian. JID-1314

borisstoyanov · 2020-06-08T18:14:54Z

@blueorangutan help

blueorangutan · 2020-06-08T18:15:53Z

@borisstoyanov I understand these words: "help", "hello", "thanks", "package", "test"
Test command usage: test [mgmt os] [hypervisor] [additional tests]
Mgmt OS options: ['centos6', 'centos7', 'ubuntu']
Hypervisor options: ['kvm-centos6', 'kvm-centos7', 'kvm-ubuntu', 'xenserver-71', 'xenserver-65sp1', 'xenserver-62sp1', 'vmware-67u3', 'vmware-65u2', 'vmware-60u2', 'vmware-55u3', 'vmware-51u1', 'vmware-50u1']
Additional tests: list of space separated tests with paths relative to the test/integration directory, for example: component/test_acl_listvm.py component/test_volumes.py
Note: when additional tests are passed, you need to specify mgmt server os and hypervisor or use the matrix command.

Blessed contributors for kicking Trillian test jobs: ['rhtyd', 'nvazquez', 'PaulAngus', 'borisstoyanov', 'DaanHoogland', 'shwstppr', 'andrijapanicsb', 'Spaceman1984', 'Pearl1594', 'davidjumani', 'harikrishna-patnala', 'vladimirpetrov', 'sureshanaparti']

borisstoyanov · 2020-06-08T18:21:47Z

@blueorangutan package

blueorangutan · 2020-06-08T18:22:58Z

@borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2020-06-08T18:30:40Z

Packaging result: ✖centos7 ✖debian. JID-1318

PaulAngus · 2020-06-08T20:51:28Z

@blueorangutan package

blueorangutan · 2020-06-08T20:52:58Z

@PaulAngus a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2020-06-08T21:00:33Z

Packaging result: ✖centos7 ✖debian. JID-1319

GabrielBrascher

LGTM 👍

GabrielBrascher · 2020-07-01T21:31:39Z

@blueorangutan package

blueorangutan · 2020-07-01T21:32:46Z

@GabrielBrascher a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2020-07-01T22:00:03Z

Packaging result: ✔centos7 ✔debian. JID-1502

borisstoyanov

LGTM, based on code

api/src/main/java/org/apache/cloudstack/query/QueryService.java

DaanHoogland

@PaulAngus are you addressing the upgrade scripts? (/me only half volunteering)

engine/schema/src/main/resources/META-INF/db/schema-410to420.sql

...mic-role-based/src/main/java/org/apache/cloudstack/acl/DynamicRoleBasedAPIAccessChecker.java

...atic-role-based/src/main/java/org/apache/cloudstack/acl/StaticRoleBasedAPIAccessChecker.java

plugins/database/mysql-ha/src/main/java/com/cloud/utils/db/StaticStrategy.java

server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java

server/src/main/java/com/cloud/network/vpc/VpcManagerImpl.java

server/src/main/java/com/cloud/vm/UserVmManagerImpl.java

yadvr · 2020-10-28T10:22:22Z

@DaanHoogland Paul may need assistance, can ask for his advice and address review issues on his behalf as well as fix the issue renaming via the upgrade path.

DaanHoogland · 2020-10-28T10:41:37Z

@DaanHoogland Paul may need assistance, can ask for his advice and address review issues on his behalf as well as fix the issue renaming via the upgrade path.

is this you volunteering, @rhtyd ?

sureshanaparti · 2021-04-09T08:38:03Z

@blueorangutan package

blueorangutan · 2021-04-09T08:39:03Z

@sureshanaparti a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2021-04-09T09:15:46Z

Packaging result: ✔️ centos7 ✔️ centos8 ✔️ debian. SL-JID 373

sureshanaparti · 2021-04-09T10:23:22Z

@blueorangutan test

blueorangutan · 2021-04-09T10:24:03Z

@sureshanaparti a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2021-04-09T23:08:26Z

Trillian test result (tid-396)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 44246 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4135-t396-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Smoke tests completed. 87 look OK, 1 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_01_migrate_VM_and_root_volume	`Error`	69.19	test_vm_life_cycle.py
test_02_migrate_VM_with_two_data_disks	`Error`	53.14	test_vm_life_cycle.py

yadvr · 2021-04-26T11:55:54Z

Further changes moved here #4922 closing this, #4922 will continue the effort.

DaanHoogland reviewed Jun 8, 2020

View reviewed changes

svenvogel added the type:cleanup label Jun 10, 2020

GabrielBrascher approved these changes Jul 1, 2020

View reviewed changes

borisstoyanov approved these changes Jul 3, 2020

View reviewed changes

yadvr reviewed Aug 13, 2020

View reviewed changes

api/src/main/java/org/apache/cloudstack/query/QueryService.java Show resolved Hide resolved

yadvr added the status:waiting-for-author label Aug 28, 2020

DaanHoogland requested changes Sep 18, 2020

View reviewed changes

yadvr mentioned this pull request Oct 27, 2020

remove blacklist and whitelist phrases apache/cloudstack-documentation#137

Merged

shwstppr mentioned this pull request Feb 1, 2021

server: prevent update vm read-only details #4629

Merged

12 tasks

DaanHoogland added this to the 4.16.0.0 milestone Feb 1, 2021

PaulAngus added 4 commits April 9, 2021 13:58

start removing dubious phrases

8a2d80b

remove black/white list phrasing

7ea817d

remove a few last phrases

d3f53e5

fix inadvertent case change

06a965d

PaulAngus and others added 4 commits April 9, 2021 13:59

wrong case

3b5f966

revert change which is actually in mysql

cd635aa

fix typo

7ea0a96

Updated changes to remove black/whitelist phrasing

2d735bf

sureshanaparti force-pushed the neutralising branch from c3c7207 to 2d735bf Compare April 9, 2021 08:35

DaanHoogland self-requested a review April 9, 2021 09:21

DaanHoogland approved these changes Apr 13, 2021

View reviewed changes

sureshanaparti marked this pull request as draft April 15, 2021 08:34

yadvr closed this Apr 26, 2021

Conversation

PaulAngus commented Jun 8, 2020

Description

Types of changes

Screenshots (if appropriate):

How Has This Been Tested?

Uh oh!

PaulAngus commented Jun 8, 2020

Uh oh!

blueorangutan commented Jun 8, 2020

Uh oh!

DaanHoogland Jun 8, 2020

Choose a reason for hiding this comment

Uh oh!

PaulAngus Jun 8, 2020

Choose a reason for hiding this comment

Uh oh!

blueorangutan commented Jun 8, 2020

Uh oh!

borisstoyanov commented Jun 8, 2020

Uh oh!

blueorangutan commented Jun 8, 2020

Uh oh!

borisstoyanov commented Jun 8, 2020

Uh oh!

blueorangutan commented Jun 8, 2020

Uh oh!

blueorangutan commented Jun 8, 2020

Uh oh!

PaulAngus commented Jun 8, 2020

Uh oh!

blueorangutan commented Jun 8, 2020

Uh oh!

blueorangutan commented Jun 8, 2020

Uh oh!

GabrielBrascher left a comment

Choose a reason for hiding this comment

Uh oh!

GabrielBrascher commented Jul 1, 2020

Uh oh!

blueorangutan commented Jul 1, 2020

Uh oh!

blueorangutan commented Jul 1, 2020

Uh oh!

borisstoyanov left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

DaanHoogland left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

yadvr commented Oct 28, 2020

Uh oh!

DaanHoogland commented Oct 28, 2020

Uh oh!

sureshanaparti commented Apr 9, 2021

Uh oh!

blueorangutan commented Apr 9, 2021

Uh oh!

blueorangutan commented Apr 9, 2021

Uh oh!

sureshanaparti commented Apr 9, 2021

Uh oh!

blueorangutan commented Apr 9, 2021

Uh oh!

blueorangutan commented Apr 9, 2021

Uh oh!

yadvr commented Apr 26, 2021

Uh oh!

Reviewers

Assignees