Skip to content

Allow direct download templates from IPv6 host address. #5900

Merged
sureshanaparti merged 3 commits intoapache:4.16from
shapeblue:allow-direct-download-templates-from-ipv6addr
Jan 28, 2022
Merged

Allow direct download templates from IPv6 host address. #5900
sureshanaparti merged 3 commits intoapache:4.16from
shapeblue:allow-direct-download-templates-from-ipv6addr

Conversation

@sureshanaparti
Copy link
Contributor

@sureshanaparti sureshanaparti commented Jan 26, 2022

Description

This PR, extends from #5826, allows only direct download templates from IPv6 host address.

Fixes #3047

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

@sureshanaparti sureshanaparti mentioned this pull request Jan 26, 2022
Closed
12 tasks
@sureshanaparti sureshanaparti linked an issue Jan 26, 2022 that may be closed by this pull request
Direct Download with IPv6 only fails #3047
Closed
@sureshanaparti sureshanaparti added this to the 4.16.1.0 milestone Jan 26, 2022
@sureshanaparti
Copy link
Contributor Author

sureshanaparti commented Jan 26, 2022

@blueorangutan package

@blueorangutan
Copy link

blueorangutan commented Jan 26, 2022

@sureshanaparti a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@DaanHoogland
Copy link
Contributor

DaanHoogland commented Jan 26, 2022

@sureshanaparti I don't see a difference between this and #5826. why recreate the PR?

@sureshanaparti
Copy link
Contributor Author

sureshanaparti commented Jan 26, 2022

@sureshanaparti I don't see a difference between this and #5826. why recreate the PR?

forgot to push the commit, check now @DaanHoogland

DaanHoogland
DaanHoogland approved these changes Jan 26, 2022
View reviewed changes
Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cltgm

weizhouapache
weizhouapache approved these changes Jan 26, 2022
View reviewed changes
Copy link
Member

@weizhouapache weizhouapache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm
have not tested it

@blueorangutan
Copy link

blueorangutan commented Jan 26, 2022

Packaging result: ✔️ el7 ✔️ el8 ✖️ debian ✖️ suse15. SL-JID 2309

@sureshanaparti
Copy link
Contributor Author

sureshanaparti commented Jan 26, 2022

@blueorangutan package

@blueorangutan
Copy link

blueorangutan commented Jan 26, 2022

@sureshanaparti a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link

blueorangutan commented Jan 26, 2022

Packaging result: ✖️ el7 ✔️ el8 ✔️ debian ✖️ suse15. SL-JID 2315

@apache apache deleted a comment from blueorangutan Jan 27, 2022
@apache apache deleted a comment from blueorangutan Jan 27, 2022
@sureshanaparti
Copy link
Contributor Author

sureshanaparti commented Jan 27, 2022

@blueorangutan package

@blueorangutan
Copy link

blueorangutan commented Jan 27, 2022

@sureshanaparti a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link

blueorangutan commented Jan 27, 2022

Packaging result: ✖️ el7 ✖️ el8 ✖️ debian ✖️ suse15. SL-JID 2331

shwstppr
shwstppr approved these changes Jan 27, 2022
View reviewed changes
Copy link
Contributor

@shwstppr shwstppr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, already tested these changes in an env having IPv6 enabled host. Direct Download template registration and thereafter VM deployment worked fine
#5826 (comment)

@sureshanaparti
Copy link
Contributor Author

sureshanaparti commented Jan 27, 2022

@blueorangutan package

@blueorangutan
Copy link

blueorangutan commented Jan 27, 2022

@sureshanaparti a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@sureshanaparti sureshanaparti self-assigned this Jan 27, 2022
@blueorangutan
Copy link

blueorangutan commented Jan 27, 2022

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 2336

@sureshanaparti
Copy link
Contributor Author

sureshanaparti commented Jan 27, 2022

@blueorangutan test

@blueorangutan
Copy link

blueorangutan commented Jan 27, 2022

@sureshanaparti a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

GabrielBrascher
GabrielBrascher approved these changes Jan 27, 2022
View reviewed changes
Copy link
Member

@GabrielBrascher GabrielBrascher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@blueorangutan
Copy link

blueorangutan commented Jan 28, 2022

Trillian test result (tid-3037)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 32135 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5900-t3037-kvm-centos7.zip
Smoke tests completed. 92 look OK, 0 have errors
Only failed tests results shown below:

Test Result Time (s) Test File

@sureshanaparti sureshanaparti merged commit 0e15095 into apache:4.16 Jan 28, 2022
@sureshanaparti sureshanaparti mentioned this pull request Jan 28, 2022
Closed
shwstppr pushed a commit to shapeblue/cloudstack that referenced this pull request Feb 4, 2022
@sureshanaparti @GabrielBrascher @shwstppr
Allow direct download templates from IPv6 host address. (apache#5900)
98071ca 
* Allow templates & ISOs from IPv6 host address.

* fix checkstyle issue

* Allow only direct download templates from IPv6 address

Co-authored-by: gabriel <gabriel@apache.org>
(cherry picked from commit 0e15095)
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shwstppr shwstppr shwstppr approved these changes

@DaanHoogland DaanHoogland DaanHoogland approved these changes

@GabrielBrascher GabrielBrascher GabrielBrascher approved these changes

@weizhouapache weizhouapache weizhouapache approved these changes

@GutoVeronezi GutoVeronezi Awaiting requested review from GutoVeronezi

Assignees

@sureshanaparti sureshanaparti

Labels

component:ipv6

Projects

No open projects
Apache CloudStack 4.16.1
Status: Done

Milestone

4.16.1.0

Development

Successfully merging this pull request may close these issues.

Direct Download with IPv6 only fails

6 participants

@sureshanaparti @blueorangutan @DaanHoogland @shwstppr @GabrielBrascher @weizhouapache