test: skip check for volume stats history on xenserver#8661
Merged
yadvr merged 1 commit intoapache:4.19from Feb 15, 2024
Merged
Conversation
boring-cyborg
bot
added
component:integration-test
Python
6 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.19 #8661 +/- ##
=============================================
- Coverage 30.90% 14.20% -16.70%
+ Complexity 34189 13355 -20834
=============================================
Files 5347 5211 -136
Lines 375566 353213 -22353
Branches 54625 50593 -4032
=============================================
- Hits 116068 50191 -65877
- Misses 244236 296347 +52111
+ Partials 15262 6675 -8587
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
DaanHoogland
approved these changes
Feb 15, 2024
Member
|
Changes small in scope and make sense. Thanks @weizhouapache |
DaanHoogland
deleted the
4.19-test-skip-volume-stats-history-xenserver
branch
dhslove
pushed a commit
to ablecloud-team/ablestack-cloud
that referenced
this pull request
Feb 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the smoke test failure with
test_list_volumes_metrics_historyon xcpng 81/82According to below code snippet, it is not supported yet
https://github.com/apache/cloudstack/blob/main/plugins/hypervisors/xenserver/src/main/java/com/cloud/hypervisor/xenserver/resource/wrapper/xenbase/CitrixGetVmDiskStatsCommandWrapper.java
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?