UI: create network form constantly tries to list domains - which is not permitted for normal users#9348
Merged
DaanHoogland merged 1 commit into4.19from Jul 8, 2024
Merged
Conversation
…ot permitted for normal users
weizhouapache
approved these changes
Jul 5, 2024
Member
weizhouapache
left a comment
There was a problem hiding this comment.
code lgtm
this issue seems to be fixed by #8919 in main branch
but it still exist in 4.19
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.19 #9348 +/- ##
============================================
- Coverage 15.05% 15.05% -0.01%
+ Complexity 11139 11136 -3
============================================
Files 5405 5405
Lines 472354 472355 +1
Branches 61210 60596 -614
============================================
- Hits 71129 71119 -10
- Misses 393302 393316 +14
+ Partials 7923 7920 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
yadvr
approved these changes
Jul 6, 2024
14 tasks
dhslove
pushed a commit
to ablecloud-team/ablestack-cloud
that referenced
this pull request
Jul 15, 2024
…ot permitted for normal users (apache#9348)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR prevents listing domains for normal users
Before fix:

After fix:

Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?