Skip to content

fix: allow positive weight only#495

Merged
leerho merged 1 commit intoapache:masterfrom
proost:fix-allow-positive-weight-only
Mar 25, 2026
Merged

fix: allow positive weight only#495
leerho merged 1 commit intoapache:masterfrom
proost:fix-allow-positive-weight-only

Conversation

@proost
Copy link
Member

@proost proost commented Mar 24, 2026

issue: #485

  1. Following the origin paper, allow positive weight only.
  2. Make a consistent const value with Java.

@proost proost requested review from jmalkin and leerho March 24, 2026 05:27
@proost proost self-assigned this Mar 24, 2026
Copy link
Member

@leerho leerho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@leerho leerho merged commit fff14b4 into apache:master Mar 25, 2026
5 checks passed
@proost proost deleted the fix-allow-positive-weight-only branch March 25, 2026 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants