Skip to content

[config] Add validation for numeric config fields#449

Open
Prajwal-banakar wants to merge 1 commit intoapache:mainfrom
Prajwal-banakar:Config-validation
Open

[config] Add validation for numeric config fields#449
Prajwal-banakar wants to merge 1 commit intoapache:mainfrom
Prajwal-banakar:Config-validation

Conversation

@Prajwal-banakar
Copy link
Contributor

Purpose

Linked issue: close #385

Add a validate_numeric_fields() method to Config that validates all numeric fields have sensible values (e.g. sizes > 0, timeouts >= 0). Validation is called during FlussConnection::new() alongside the existing validate_security() and validate_scanner_fetch() checks.

Brief change log

  • Added validate_numeric_fields() in config.rs covering 10 numeric fields
  • Called validate_numeric_fields() in FlussConnection::new() in connection.rs
  • Added 11 unit tests covering default validity and each invalid case

Tests

cargo fmt --all
cargo clippy -p fluss-rs --all-features
cargo test -p fluss-rs

API and Format

API: No breaking changes
Storage format: No

Documentation

No doc changes needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Config validation for numeric fields

1 participant