[config] Add validation for numeric config fields#449
Open
Prajwal-banakar wants to merge 1 commit intoapache:mainfrom
Open
[config] Add validation for numeric config fields#449Prajwal-banakar wants to merge 1 commit intoapache:mainfrom
Prajwal-banakar wants to merge 1 commit intoapache:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #385
Add a
validate_numeric_fields()method toConfigthat validates all numeric fields have sensible values (e.g. sizes > 0, timeouts >= 0). Validation is called duringFlussConnection::new()alongside the existingvalidate_security()andvalidate_scanner_fetch()checks.Brief change log
validate_numeric_fields()inconfig.rscovering 10 numeric fieldsvalidate_numeric_fields()inFlussConnection::new()inconnection.rsTests
cargo fmt --all
cargo clippy -p fluss-rs --all-features
cargo test -p fluss-rs
API and Format
API: No breaking changes
Storage format: No
Documentation
No doc changes needed.