IGNITE-17915 Support extensible injection mechanism handling.#10337
IGNITE-17915 Support extensible injection mechanism handling.#10337splatch wants to merge 8 commits intoapache:masterfrom
Conversation
First part of changes which opens some of ignite internal classes for re-use within IoC scenarios. Signed-off-by: Łukasz Dywicki <luke@code-house.org>
e8a9879 to
c919048
Compare
|
Hi, @splatch! I took the liberty to update your PR (just so it could pass our TeamCity checks). Everything else looks good to me. Here's one suggestion though: how about we wrap |
|
Hello @SammyVimes, thank you for picking it up and following it. I was afraid of submitting this PR as I was not able to run all the tests, hence I was not able to confirm it prior doing official attempt. If you can hold for few days I will use this time to make a prototype of injection registry working under osgi to confirm whole concept works beyond Spring. I will be able to contribute other thing to |
|
Hi @splatch! I added a spring bridge to the core module, so that we could remove |
|
As for next steps: I agree, we should implement spring and osgi injectors (in their respective modules) |
|
@SammyVimes I managed to get registries for other components, however I could not test ignite-ext at all due to OSGi metadata troubles both for core and ext modules themselves. I made an attempt to adjust feature file and ignite-osgi-ext tests, but I failed to make any progress. It probably requires partial, if not complete, rewrite due to outdated dependencies and changes in tooling. I will test changes within opennms build where we do "wrapping" of ignite-core making it work under Apache Karaf. Will let you know about results and try to book more time for ignite osgi adjustments later this year. |
First part of changes which opens some of ignite internal classes for re-use within IoC scenarios.
This is proposed way which utilize most of existing ioc code provided for Spring framework.
Some of internal classes had to be marked as public, so they might work outside of own package.
The Contribution Checklist
The description explains WHAT and WHY was made instead of HOW.
The following pattern must be used:
IGNITE-XXXX Change summarywhereXXXX- number of JIRA issue.(see the Maintainers list)
the
green visaattached to the JIRA ticket (see TC.Bot: Check PR)