PARQUET-1499: Add Java 11 to Travis by Fokko · Pull Request #596 · apache/parquet-java

Fokko · 2019-01-21T18:21:32Z

https://issues.apache.org/jira/browse/PARQUET-1497

gszadovszky

Thanks a lot for this fix. Please, check my comments.

dev/Dockerfile

.travis.yml

gszadovszky

Waiting for the fixes of the java11 related issues. I'll push it if Travis tests pass.

Fokko · 2019-01-30T11:28:06Z

Rebased.

Fokko · 2019-02-10T18:35:06Z

Thrift was using Gradle 4.4.1, but has been updated to 5.1.1 which supports Java11:
apache/thrift@98f379e#diff-7762a898c27a3d29c23245cc2abd99baR5

Fokko · 2019-06-19T13:35:27Z

I've split some of the stuff in this PR into #656 and #654 to make the PR's nice and manageable. For this PR, we're still dependent on #605. After updating Scala, I expect the CI to pass.

Got some weird warnings from generated code: [ERROR] Failed to execute goal org.apache.maven.plugins:maven-javadoc-plugin:2.9.1:javadoc (default-cli) on project parquet-format-structures: An error has occurred in JavaDocs report generation: [ERROR] Exit code: 1 - javadoc: error - The code being documented uses modules but the packages defined in http://docs.oracle.com/javase/7/docs/api/ are in the unnamed module. [ERROR] /home/travis/build/apache/parquet-mr/parquet-format-structures/target/generated-sources/thrift/org/apache/parquet/format/ColumnIndex.java:49: warning - invalid usage of tag < [ERROR] /home/travis/build/apache/parquet-mr/parquet-format-structures/target/generated-sources/thrift/org/apache/parquet/format/ColumnIndex.java:394: warning - invalid usage of tag < [ERROR] /home/travis/build/apache/parquet-mr/parquet-format-structures/target/generated-sources/thrift/org/apache/parquet/format/ColumnIndex.java:407: warning - invalid usage of tag < [ERROR] /home/travis/build/apache/parquet-mr/parquet-format-structures/target/generated-sources/thrift/org/apache/parquet/format/ColumnIndex.java:84: warning - invalid usage of tag < [ERROR] /home/travis/build/apache/parquet-mr/parquet-format-structures/target/generated-sources/thrift/org/apache/parquet/format/OffsetIndex.java:21: warning - invalid usage of tag < [ERROR] /home/travis/build/apache/parquet-mr/parquet-format-structures/target/generated-sources/thrift/org/apache/parquet/format/OffsetIndex.java:150: warning - invalid usage of tag < [ERROR] /home/travis/build/apache/parquet-mr/parquet-format-structures/target/generated-sources/thrift/org/apache/parquet/format/OffsetIndex.java:159: warning - invalid usage of tag < [ERROR] /home/travis/build/apache/parquet-mr/parquet-format-structures/target/generated-sources/thrift/org/apache/parquet/format/OffsetIndex.java:29: warning - invalid usage of tag < [ERROR] /home/travis/build/apache/parquet-mr/parquet-format-structures/target/generated-sources/thrift/org/apache/parquet/format/ColumnIndex.java:49: warning - invalid usage of tag < [ERROR] /home/travis/build/apache/parquet-mr/parquet-format-structures/target/generated-sources/thrift/org/apache/parquet/format/OffsetIndex.java:21: warning - invalid usage of tag <

So we can run it in Docker as well

…a-11-builds

Fokko · 2019-10-25T22:45:00Z

Rebased onto master and it is green now :-)

Got some weird warnings from generated code: [ERROR] Failed to execute goal org.apache.maven.plugins:maven-javadoc-plugin:2.9.1:javadoc (default-cli) on project parquet-format-structures: An error has occurred in JavaDocs report generation: [ERROR] Exit code: 1 - javadoc: error - The code being documented uses modules but the packages defined in http://docs.oracle.com/javase/7/docs/api/ are in the unnamed module. [ERROR] /home/travis/build/apache/parquet-mr/parquet-format-structures/target/generated-sources/thrift/org/apache/parquet/format/ColumnIndex.java:49: warning - invalid usage of tag < [ERROR] /home/travis/build/apache/parquet-mr/parquet-format-structures/target/generated-sources/thrift/org/apache/parquet/format/ColumnIndex.java:394: warning - invalid usage of tag < [ERROR] /home/travis/build/apache/parquet-mr/parquet-format-structures/target/generated-sources/thrift/org/apache/parquet/format/ColumnIndex.java:407: warning - invalid usage of tag < [ERROR] /home/travis/build/apache/parquet-mr/parquet-format-structures/target/generated-sources/thrift/org/apache/parquet/format/ColumnIndex.java:84: warning - invalid usage of tag < [ERROR] /home/travis/build/apache/parquet-mr/parquet-format-structures/target/generated-sources/thrift/org/apache/parquet/format/OffsetIndex.java:21: warning - invalid usage of tag < [ERROR] /home/travis/build/apache/parquet-mr/parquet-format-structures/target/generated-sources/thrift/org/apache/parquet/format/OffsetIndex.java:150: warning - invalid usage of tag < [ERROR] /home/travis/build/apache/parquet-mr/parquet-format-structures/target/generated-sources/thrift/org/apache/parquet/format/OffsetIndex.java:159: warning - invalid usage of tag < [ERROR] /home/travis/build/apache/parquet-mr/parquet-format-structures/target/generated-sources/thrift/org/apache/parquet/format/OffsetIndex.java:29: warning - invalid usage of tag < [ERROR] /home/travis/build/apache/parquet-mr/parquet-format-structures/target/generated-sources/thrift/org/apache/parquet/format/ColumnIndex.java:49: warning - invalid usage of tag < [ERROR] /home/travis/build/apache/parquet-mr/parquet-format-structures/target/generated-sources/thrift/org/apache/parquet/format/OffsetIndex.java:21: warning - invalid usage of tag <

gszadovszky requested changes Jan 22, 2019

View reviewed changes

dev/Dockerfile Outdated Show resolved Hide resolved

.travis.yml Outdated Show resolved Hide resolved

Fokko force-pushed the fd-add-java-11-builds branch from e401cfa to d4e8ebb Compare January 22, 2019 10:11

gszadovszky approved these changes Jan 22, 2019

View reviewed changes

nandorKollar approved these changes Jan 22, 2019

View reviewed changes

Fokko mentioned this pull request Jan 25, 2019

[PARQUET-1507] Bump Apache Thrift to 0.12.0 #601

Merged

Fokko force-pushed the fd-add-java-11-builds branch from d4e8ebb to a103088 Compare January 30, 2019 11:27

Fokko force-pushed the fd-add-java-11-builds branch from a103088 to 7ebbfb7 Compare February 5, 2019 22:05

Fokko force-pushed the fd-add-java-11-builds branch from 7ebbfb7 to 54d8490 Compare May 10, 2019 11:14

Fokko mentioned this pull request May 26, 2019

PARQUET-1573: Add a docker development image and use it in travis #637

Open

zivanfi changed the title ~~[PARQUET-1499] Enable JDK11 build~~ PARQUET-1499: Enable JDK11 build Jun 11, 2019

zivanfi changed the title ~~PARQUET-1499: Enable JDK11 build~~ PARQUET-1499: Add Java 11 to Travis Jun 11, 2019

Fokko force-pushed the fd-add-java-11-builds branch 4 times, most recently from 71c35c9 to e9485ab Compare June 19, 2019 09:48

Fokko force-pushed the fd-add-java-11-builds branch from e9485ab to 9da1fe1 Compare June 19, 2019 11:18

Fokko Driesprong and others added 11 commits July 4, 2019 11:12

PARQUET-1499: Enable JDK11 build

9c25c5e

Don't compile the Java extension

f0b9504

Disable the lint

51b90e7

Remove sudo from the setup script

75a8845

So we can run it in Docker as well

Bump maven-javadoc-plugin

e7664a9

Add root again

ae7c372

Ignore the Thrift doclint errors

9c4ea44

chmod +x

bfae72b

Don't compile stuff we don't use

013496d

Bump to xenial

4fa6f40

Fokko added 6 commits July 4, 2019 11:12

Add an upgrade step which wil hopefully upgrade OPENJDK 11.0.2 to 11.0.3

48f987b

Add y

0e905f6

Remove the upgrade

b8fbb60

Set the source

9d67e8f

Bump to Javadoc 3.1.0

6f36862

PARQUET-1550: CleanUtil does not work in Java 11

ad4697e

Fokko force-pushed the fd-add-java-11-builds branch from 9da1fe1 to ad4697e Compare July 4, 2019 09:14

Fokko added 3 commits September 9, 2019 17:43

Merge branch 'master' into fd-add-java-11-builds

d01735d

Merge branch 'master' of github.com:apache/parquet-mr into fd-add-jav…

e8ff617

…a-11-builds

Merge branch 'master' of github.com:apache/parquet-mr into fd-add-jav…

9e6aff9

…a-11-builds

Fokko merged commit 19b10ac into apache:master Oct 25, 2019

Fokko deleted the fd-add-java-11-builds branch October 25, 2019 23:06

asfimport mentioned this pull request Jun 23, 2024

[parquet-mr] Add Java 11 to Travis #1543

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

PARQUET-1499: Add Java 11 to Travis#596

PARQUET-1499: Add Java 11 to Travis#596
Fokko merged 20 commits intoapache:masterfrom
Fokko:fd-add-java-11-builds

Fokko commented Jan 21, 2019

Uh oh!

gszadovszky left a comment

Uh oh!

Uh oh!

Uh oh!

gszadovszky left a comment

Uh oh!

Fokko commented Jan 30, 2019

Uh oh!

Fokko commented Feb 10, 2019

Uh oh!

Fokko commented Jun 19, 2019

Uh oh!

Fokko commented Oct 25, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

Fokko commented Jan 21, 2019

Uh oh!

gszadovszky left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

gszadovszky left a comment

Choose a reason for hiding this comment

Uh oh!

Fokko commented Jan 30, 2019

Uh oh!

Fokko commented Feb 10, 2019

Uh oh!

Fokko commented Jun 19, 2019

Uh oh!

Fokko commented Oct 25, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants