PARQUET-1496: Update Scala to 2.12#693
Merged
nandorKollar merged 3 commits intoapache:masterfrom Oct 25, 2019
Merged
Conversation
This also includes updating Scrooge because it isn't compiled anymore against Scala 2.10
| @@ -1,14 +1,14 @@ | |||
| /* | |||
Contributor
There was a problem hiding this comment.
This file has only style changes, would you mind reverting it?
Contributor
Author
There was a problem hiding this comment.
I've reverted a couple more unrelated changes.
956cc38 to
38c472e
Compare
ScroogeBinaryTest.java ThriftParquetReader.java
38c472e to
2d81079
Compare
Contributor
Author
|
Does someone have some spare time to review this? Would be great to move Java 11 support forward. |
gszadovszky
approved these changes
Oct 24, 2019
Contributor
Author
|
@nandorKollar Are you fine with the current PR as is? 👍 |
nandorKollar
approved these changes
Oct 25, 2019
Contributor
|
Sure, thanks @Fokko! |
shangxinli
pushed a commit
to shangxinli/parquet-mr
that referenced
this pull request
Dec 16, 2019
* PARQUET-1496: Update Scala to 2.12 This also includes updating Scrooge because it isn't compiled anymore against Scala 2.10 * Fix the tests * Revert unrelated changes ScroogeBinaryTest.java ThriftParquetReader.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure you have checked all steps below. Updated the tests a bit as well. There were some conflicts between both
test.thriftfiles. I've consolidated them to avoid issues.Updating to Scala 2.12 is required to support Java 11.
Jira
Tests
Commits
Documentation