Upgrade to Jetty 10 maven plugin#72
Conversation
…ium tests, upgrades Jetty to v10 and Selenium to 3.14.0. I left the it-selenium commented out in the parent POM because it requires that geckodriver be installed.
# Conflicts: # it-selenium/pom.xml # it-selenium/src/test/java/org/apache/roller/selenium/AbstractRollerPage.java # it-selenium/src/test/java/org/apache/roller/selenium/InitialLoginTestIT.java # it-selenium/src/test/java/org/apache/roller/selenium/core/MainMenuPage.java # it-selenium/src/test/java/org/apache/roller/selenium/core/RegisterPage.java
snoopdave
changed the title
| <version>6.1.0-SNAPSHOT</version> | ||
| <packaging>pom</packaging> | ||
|
|
||
| <prerequisites> |
There was a problem hiding this comment.
This prerequisites tag is only to be used with Maven Plugin project POMs, not plain old modules like Roller's.
|
@snoopdave did you mean Jetty 10? Jetty 11 runs Jakarta EE 9 and most dependencies are not ready for that yet. |
| <maven-antrun.version>1.0b3</maven-antrun.version> | ||
| <rome.version>1.13.1</rome.version> | ||
| <slf4j.version>1.7.30</slf4j.version> | ||
| <spring.version>5.2.7.RELEASE</spring.version> |
There was a problem hiding this comment.
was this intended? spring and spring sec are now defined in two different poms. (asking before i rebase)
does this help to reduce selenium warnings or has it other reasons?
There was a problem hiding this comment.
I was trying to use dependencyManagement in the parent POM to force all Spring deps to the same version, but I don't think it really helped with all those warnings you see when Jetty starts in app or it-selenium.
I'm going to back this change out.
snoopdave
changed the title
Yes. Thanks! I edited the title to fix that. |
2 participants
Also some attempts to reduce number of warnings about classes loaded from multiple locations, and some import cleanups. This change also makes it possible to run
mvn jetty:runfrom the top-level directory and not only in theappmodule.