Deprections, compiler warning fixes, local refactorings and JDK 17 support#96
Merged
mbien merged 19 commits intoapache:masterfrom Aug 8, 2021
Merged
Deprections, compiler warning fixes, local refactorings and JDK 17 support#96mbien merged 19 commits intoapache:masterfrom
mbien merged 19 commits intoapache:masterfrom
Conversation
snoopdave
approved these changes
Aug 8, 2021
Contributor
snoopdave
left a comment
There was a problem hiding this comment.
Works for me. I built and ran on JDK17 and did not notice any problems.
I did notice one error in tests but I think it is fixed in master:
[ERROR] Errors:
[ERROR] SingleThreadedFeedUpdaterTest.testUpdateSubscription:72 » Updater Error fetchi...
Member
Author
hmm. This test usually fails when rollerblogger.org is temporary unreachable since it relies on its feed. I tested this PR again and everything was green except the IPBanListTest, but the test itself has some file-io race conditions on my system - but this would be unrelated to this PR. Going to integrate this but keep an eye on the test :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Worked myself though the compiler warnings. This looks like a lot of changes, but the individual changes are all very local.