SOLR-18166: Remove 'linkconfig' tool and related code#4232
Open
gerlowskija wants to merge 2 commits intoapache:mainfrom
Open
SOLR-18166: Remove 'linkconfig' tool and related code#4232gerlowskija wants to merge 2 commits intoapache:mainfrom
gerlowskija wants to merge 2 commits intoapache:mainfrom
Conversation
"Linkconfig" is a functionality initially added prior to our collection-admin APIs, when users needed to run manual commands to associate or "link" a new collection with a particular config by storing the config name on the /collections/<collName> node. Storing config information in this location was deprecated in SOLR-14341 and can be removed now that 10.0 is out the door. This commit removes several methods that checked for config info at this location, as well as the "linkconfig" that was user's primary way of storing this information in the past.
epugh
reviewed
Mar 21, 2026
Contributor
epugh
left a comment
epugh
left a comment
There was a problem hiding this comment.
LGTM. I was surprised nothing in bin/solr and ref guide needed removing?
| * @return the ClusterState | ||
| */ | ||
| @SuppressWarnings({"unchecked"}) | ||
| @Deprecated |
dsmiley
approved these changes
Mar 21, 2026
| * @return the ClusterState | ||
| */ | ||
| @SuppressWarnings({"unchecked"}) | ||
| @Deprecated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SOLR-18166
Description
"Linkconfig" is a functionality initially added prior to our collection-admin APIs, when users needed to run manual commands to associate or "link" a new collection with a particular config by storing the config name on the /collections/ node.
Storing config information in this location was deprecated in SOLR-14341 and can be removed now that 10.0 is out the door.
Solution
This commit removes several methods that checked for config info at this location, as well as the "linkconfig" that was user's primary way of storing this information in the past.
Tests
Modifies ZkSubcommandsTest, but doesn't add any net-new tests as this PR is mainly removing dead code rather than adding new functionality.
Checklist
Please review the following and check all that apply:
mainbranch../gradlew check.