tests/gold_tests/headers tests: use ATSReplayTest#13033
Open
bneradt wants to merge 1 commit intoapache:masterfrom
Open
tests/gold_tests/headers tests: use ATSReplayTest#13033bneradt wants to merge 1 commit intoapache:masterfrom
bneradt wants to merge 1 commit intoapache:masterfrom
Conversation
bneradt
force-pushed
the
headers-atsreplay
branch
from
2435315 to
b529275
Compare
bneradt
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
Converts several tests/gold_tests/headers autests from bespoke Python orchestration to the ATSReplayTest (Proxy Verifier replay YAML) format.
Changes:
- Replaced multiple header-related gold tests’ Python setup/traffic generation with
Test.ATSReplayTest(...). - Added new replay YAML files (and related config assets) to encode the same scenarios in replay format.
- Added header_rewrite rule files and a regex_remap map file to support replay-driven configuration.
Reviewed changes
Copilot reviewed 22 out of 22 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/gold_tests/headers/rewrite_rules/header_rewrite_rules_308.conf | New header_rewrite rules file used by replay-based redirect coverage. |
| tests/gold_tests/headers/rewrite_rules/header_rewrite_rules_307.conf | New header_rewrite rules file used by replay-based redirect coverage. |
| tests/gold_tests/headers/rewrite_rules/header_rewrite_rules_302.conf | New header_rewrite rules file used by replay-based redirect coverage. |
| tests/gold_tests/headers/rewrite_rules/header_rewrite_rules_301.conf | New header_rewrite rules file used by replay-based redirect coverage. |
| tests/gold_tests/headers/rewrite_rules/header_rewrite_rules_0.conf | New header_rewrite rules file for the unsupported redirect status case. |
| tests/gold_tests/headers/replays/range.replay.yaml | New replay converting the Range request test to ATSReplayTest format. |
| tests/gold_tests/headers/replays/normalized_ae_varied_transactions.replay.yaml | Adds autest configuration to run this replay via ATSReplayTest. |
| tests/gold_tests/headers/replays/invalid_range_request.replay.yaml | Adds autest configuration and replay-side proxy-response validation for 416. |
| tests/gold_tests/headers/replays/hsts.replay.yaml | New replay converting the HSTS test to ATSReplayTest format. |
| tests/gold_tests/headers/replays/domain-blacklist-30x.replay.yaml | New replay converting redirect/blacklist behavior to ATSReplayTest format. |
| tests/gold_tests/headers/replays/cached_ims_range.replay.yaml | New replay converting cached IMS/INM/range and regex_remap 304 handling to ATSReplayTest format. |
| tests/gold_tests/headers/replays/cache-test.replay.yaml | Adds autest configuration to run this replay via ATSReplayTest. |
| tests/gold_tests/headers/replays/accept_webp.replay.yaml | New replay converting accept-webp alternate behavior to ATSReplayTest format. |
| tests/gold_tests/headers/range.test.py | Simplified to invoke Test.ATSReplayTest with the new range replay. |
| tests/gold_tests/headers/normalized_ae_match_vary_cache.test.py | Simplified to invoke Test.ATSReplayTest with the normalized AE replay. |
| tests/gold_tests/headers/maps.reg | New regex_remap rules file used by the cached IMS/range replay. |
| tests/gold_tests/headers/invalid_range_header.test.py | Simplified to invoke Test.ATSReplayTest with the invalid-range replay. |
| tests/gold_tests/headers/hsts.test.py | Simplified to invoke Test.ATSReplayTest with the HSTS replay. |
| tests/gold_tests/headers/domain-blacklist-30x.test.py | Simplified to invoke Test.ATSReplayTest with the redirects replay. |
| tests/gold_tests/headers/cachedIMSRange.test.py | Simplified to invoke Test.ATSReplayTest with the cached IMS/range replay. |
| tests/gold_tests/headers/cachedDuplicateHeaders.test.py | Simplified to invoke Test.ATSReplayTest with the cached duplicate headers replay. |
| tests/gold_tests/headers/accept_webp.test.py | Simplified to invoke Test.ATSReplayTest with the accept-webp replay. |
masaori335
reviewed
Mar 31, 2026
| .format(ts.Variables.port), | ||
| ts=ts) | ||
| tr.Processes.Default.ReturnCode = 0 | ||
| tr.Processes.Default.Streams.stderr = "gold/accept_webp.gold" |
Contributor
There was a problem hiding this comment.
This PR is moving these gold file checks to replay.yaml. We need to delete this old gold files?
Contributor
Author
There was a problem hiding this comment.
Removed the orphaned gold files in 16bb850 and reran the focused headers ATSReplayTest batch in the fix_tickets_4 container.
Move the replay-friendly headers gold tests to ATSReplayTest wrappers and describe their ATS, origin, and client setup in replay YAML. This keeps the cache, range, redirect, HSTS, and alternate handling coverage while making the tests easier to read and maintain, and removes the old gold files left orphaned by the conversion.
bneradt
force-pushed
the
headers-atsreplay
branch
from
a153b84 to
16bb850
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This converts the headers autests to use the ATSReplayTest format.