docs(examples): enforce and fix all mypy errors#1393
Merged
heitorlessa merged 26 commits intoaws-powertools:developfrom Jul 28, 2022
Merged
docs(examples): enforce and fix all mypy errors#1393heitorlessa merged 26 commits intoaws-powertools:developfrom
heitorlessa merged 26 commits intoaws-powertools:developfrom
Conversation
Signed-off-by: heitorlessa <lessa@amazon.co.uk>
Contributor
Author
|
Looking at the best way to provide up-to-date doc while supporting older Python versions. |
…ws-lambda-powertools-python into docs/examples-mypy * 'docs/examples-mypy' of https://github.com/heitorlessa/aws-lambda-powertools-python: chore(mypy): use backward compatible List annotation
7 tasks
Contributor
Author
|
Related PR #1395 required to merge first otherwise we can't resolve dependencies to proceed with backwards compatible TypedDict |
…tools-python into docs/examples-mypy * 'develop' of https://github.com/awslabs/aws-lambda-powertools-python: chore(ci): drop 3.6 from workflows (aws-powertools#1395) chore(maintainers): add Ruben as a maintainer (aws-powertools#1392)
Codecov Report
@@ Coverage Diff @@
## develop #1393 +/- ##
========================================
Coverage 99.88% 99.88%
========================================
Files 119 119
Lines 5429 5429
Branches 620 620
========================================
Hits 5423 5423
Misses 2 2
Partials 4 4
Continue to review full report at Codecov.
|
rubenfonseca
approved these changes
Jul 28, 2022
heitorlessa
added a commit
that referenced
this pull request
Jul 29, 2022
…tools-python into develop * 'develop' of https://github.com/awslabs/aws-lambda-powertools-python: feat(idempotency): handle lambda timeout scenarios for INPROGRESS records (#1387) chore(deps): bump jsii from 1.57.0 to 1.63.1 (#1390) chore(deps): bump constructs from 10.1.1 to 10.1.59 (#1396) chore(deps-dev): bump flake8-isort from 4.1.1 to 4.1.2.post0 (#1384) docs(examples): enforce and fix all mypy errors (#1393) chore(ci): drop 3.6 from workflows (#1395)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: #1389
Summary
Changes
This fixes 50 static typing errors, some customer facing others being mostly due to sentinel values not having a proper typing solution yet.
List of all errors fixed
User experience
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.
View rendered docs/core/event_handler/api_gateway.md