Conversation
Downloads runTests.sh and docker-compose.yml, modify for the selected extensions and put it into Build folder.
cbff807 to
f5e95b9
Compare
This way we have more control over the files/features.
… code templates to *.php
…patible with AbstractComponent
3ec2c32 to
0d4780b
Compare
o-ba
left a comment
There was a problem hiding this comment.
Besides the comments in the code, I also encounter misbehaviour on executing the command multiple times (without removing the created files):
- For some reason is the content of the CodeTemplates written to the CLI
- Both files are reported as missing, while directly after the note, the "the file does already exist" confirmation dialog is displayed.
ochorocho
left a comment
There was a problem hiding this comment.
Thanks for reviewing :-)
1. For some reason is the content of the CodeTemplates written to the CLI
Done, was caused by $this->initializeArrayConfiguration($file, $folder); which is superfluous
2. Both files are reported as missing, while directly after the note, the "the file does already exist" confirmation dialog is displayed.
Due to the removal of $this->initializeArrayConfiguration($file, $folder); this is no longer the case.
|
@ochorocho I updated parts of the code and think we now have a basis which could get merged. Final task before merging would be to check whether there were changes in the meantime which should be added to |
|
@o-ba updated runTests.sh and docker-compose.yaml . Could not include the checkNamespaceIntegrity option because this requires the cores Tests/ folder. |
2ed1365 to
ad24b28
Compare
ad24b28 to
297e01e
Compare
Apply runTests.sh and docker-compose.yml templates, modify and store it in the Build folder.
EDIT: Does a few things more now
lintcommand orphp-cs-fixergetName()does not contain any file extension, assume it's php