Skip to content

Change nodetool to permit zero parameter rpc calls#155

Merged
kellymclaughlin merged 1 commit intodevelopfrom
feature/nodetool-zero-arg-rpc
Jul 24, 2014
Merged

Change nodetool to permit zero parameter rpc calls#155
kellymclaughlin merged 1 commit intodevelopfrom
feature/nodetool-zero-arg-rpc

Conversation

@kellymclaughlin
Copy link
Copy Markdown
Contributor

Change nodetool so that functions of zero arity may be called using
the supplied rpc facility. This is done by making a distinction
between the case when rpc parameters are present and when they are
not.

Previously calling zero arity functions has not been possible because
even submitting no rpc parameters is treated the same as submitting
the request with a single parameter of an empty list. Nodetool
encapsulates any parameters as a list and the result of attempting to
call a function that takes no parameters was the rpc function calling
the supplied function with a single parameter of an empty list.

This change does not preclude calling functions with a single
parameter of an empty list. It just now makes that decision explicit
on the part of the caller.

Change nodetool so that functions of zero arity may be called using
the supplied rpc facility. This is done by making a distinction
between the case when rpc parameters are present and when they are
not.

Previously calling zero arity functions has not been possible because
even submitting no rpc parameters is treated the same as submitting
the request with a single parameter of an empty list.  Nodetool
encapsulates any parameters as a list and the result of attempting to
call a function that takes no parameters was the rpc function calling
the supplied function with a single parameter of an empty list.

This change does not preclude calling functions with a single
parameter of an empty list. It just now makes that decision explicit
on the part of the caller.
@kuenishi
Copy link
Copy Markdown

+1, works as advertised

@kellymclaughlin
Copy link
Copy Markdown
Contributor Author

I'll wait for some input from @jaredmorrow before merging. Since this repo was just branched for 2.0 maybe I should reopen against that branch for more cohesive tagging?

@jaredmorrow
Copy link
Copy Markdown
Contributor

You want this in 2.0 or no?

@kellymclaughlin
Copy link
Copy Markdown
Contributor Author

You want this in 2.0 or no?

I'd like it for Riak CS 1.5, but that is independent of 2.0 at this point.

@jaredmorrow
Copy link
Copy Markdown
Contributor

+1 to this just merging in here, I'll come back to it at RC2 if things are looking well on CS 1.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants