Fix permissions before building package on Solaris#208
Merged
JeetKunDoug merged 1 commit intodevelopfrom Oct 1, 2016
Merged
Conversation
umask/bad file permissions issues.
bsparrow435
approved these changes
Oct 1, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
pkgprototool on Solaris (like many other OSes) uses the filesystem permissions of the template installation on disk as the desired install permissions. Due to a strict (0077) umask set on some of our build infrastructure, many of the files/directories in the package did not have the appropriate permissions, even though testing before build on other Solaris machines (with less-restrictive umask settings) showed the correct permissions.This PR sets the filesystem permissions correctly in the
reldirectory before runningpkgprotoso that it picks up the correct permissions.This resolves #206 (TOOLS-345).