-
Notifications
You must be signed in to change notification settings - Fork 13
Custom promise type for managing global sshd configuration #128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
larsewi
wants to merge
4
commits into
cfengine:master
Choose a base branch
from
larsewi:sshd
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
c817bb3
Add extraPaths to pyrightconfig for local library resolution
larsewi 489311a
Custom promise type for managing global sshd configuration
larsewi a300170
Rewrite sshd promise type to use the keyword as the promiser
larsewi f024caf
Added note about conflicting sshd promises
larsewi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| MIT License | ||
|
|
||
| Copyright (c) 2026 Northern.tech | ||
|
|
||
| Permission is hereby granted, free of charge, to any person obtaining a copy | ||
| of this software and associated documentation files (the "Software"), to deal | ||
| in the Software without restriction, including without limitation the rights | ||
| to use, copy, modify, merge, publish, distribute, sublicense, and/or sell | ||
| copies of the Software, and to permit persons to whom the Software is | ||
| furnished to do so, subject to the following conditions: | ||
|
|
||
| The above copyright notice and this permission notice shall be included in all | ||
| copies or substantial portions of the Software. | ||
|
|
||
| THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
| IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
| FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE | ||
| AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
| LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
| OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE | ||
| SOFTWARE. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,63 @@ | ||
| # `sshd` promise type | ||
|
|
||
| Configures sshd and restarts the service when configuration changes. | ||
|
|
||
| ## Promiser | ||
| The sshd configuration keyword to manage (e.g. `PermitRootLogin`, `AllowUsers`). | ||
| Each promise manages a single directive in the drop-in config file. | ||
|
|
||
| ## Attributes | ||
| - `value` (required) — the value for the directive, either a string or an slist | ||
|
|
||
| ## What the module manages internally | ||
| 1. **Include directive** — ensures the base `sshd_config` includes the drop-in directory (`sshd_config.d/`) as its first non-comment directive | ||
| 2. **Drop-in directory** — creates the drop-in directory if it doesn't exist | ||
| 3. **Drop-in file** — writes directives to `sshd_config.d/00-cfengine.conf` | ||
| 4. **Service restart** — restarts sshd if configuration was changed and the service is already running | ||
| 5. **Verification** — verifies the desired directive appears in the effective sshd config (`sshd -T`) | ||
|
|
||
| ## Conflicting promisers | ||
| Having multiple promises with the same sshd keyword is not recommended. | ||
| In case of conflicting promisers, the agent will attempt to converge the correct state for each one in the order they are evaluated. | ||
| This means the last promise wins and determines the final value in the configuration file. | ||
| It will also cause multiple restarts of the sshd service, which may be disruptive. | ||
|
|
||
| ## What the module does NOT do | ||
| - Install sshd — that is a `packages:` promise | ||
| - Ensure sshd is running — that is a `services:` promise | ||
| - Manage match blocks — those are a policy-level concern | ||
|
|
||
| ## Policy | ||
| ```cf3 | ||
| bundle agent sshd_config | ||
| { | ||
| packages: | ||
| "openssh-server" policy => "present"; | ||
|
|
||
| services: | ||
| "sshd" service_policy => "start"; | ||
|
|
||
| vars: | ||
| "allowed_users" slist => { "alice", "bob" }; | ||
|
|
||
| sshd: | ||
| "PermitRootLogin" value => "no"; | ||
| "PasswordAuthentication" value => "no"; | ||
| "Port" value => "22"; | ||
| "AllowUsers" value => @(allowed_users); | ||
| } | ||
| ``` | ||
|
|
||
| ## Authors | ||
|
|
||
| This software was created by the team at [Northern.tech](https://northern.tech), with many contributions from the community. | ||
| Thanks everyone! | ||
|
|
||
| ## Contribute | ||
|
|
||
| Feel free to open pull requests to expand this documentation, add features, or fix problems. | ||
| You can also pick up an existing task or file an issue in [our bug tracker](https://northerntech.atlassian.net/). | ||
|
|
||
| ## License | ||
|
|
||
| This software is licensed under the MIT License. See LICENSE in the root of the repository for the full license text. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| promise agent sshd | ||
| # @brief Define sshd promise type | ||
| { | ||
| path => "$(sys.workdir)/modules/promises/sshd_promise_type.py"; | ||
| interpreter => "/usr/bin/python3"; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| promise agent sshd | ||
| # @brief Define sshd promise type | ||
| { | ||
| path => "$(sys.workdir)/modules/promises/sshd_promise_type.py"; | ||
| interpreter => "/usr/bin/python3"; | ||
| } | ||
|
|
||
| bundle agent example | ||
| { | ||
| packages: | ||
| "openssh-server" policy => "present"; | ||
|
|
||
| services: | ||
| "sshd" service_policy => "start"; | ||
|
|
||
| vars: | ||
| "allowed_users" slist => { "alice", "bob" }; | ||
|
|
||
| sshd: | ||
| "PermitRootLogin" value => "no"; | ||
| "PasswordAuthentication" value => "no"; | ||
| "Port" value => "22"; | ||
| "AllowUsers" value => @(allowed_users); | ||
| } | ||
|
|
||
| bundle agent __main__ | ||
| { | ||
| methods: | ||
| "example"; | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.