fix: Padding is ignored for Output frames/#694
Open
majiayu000 wants to merge 1 commit intocharmbracelet:mainfrom
Open
fix: Padding is ignored for Output frames/#694majiayu000 wants to merge 1 commit intocharmbracelet:mainfrom
Output frames/#694majiayu000 wants to merge 1 commit intocharmbracelet:mainfrom
Conversation
Previously, when using `Output frames/`, the raw frames were simply moved to the output directory without any styling applied (padding, window bar, margins, border radius). This fix adds a `MakeFrames` function that processes all frames through FFmpeg with the same filters used for video and screenshot outputs. Changes: - Add MakeFrames function in video.go to process frames with FFmpeg filters - Add buildFrameFFopts helper for assembling FFmpeg arguments per frame - Update Render method in vhs.go to include frame processing - Remove the simple rename logic from evaluator.go defer block Fixes charmbracelet#258 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> Signed-off-by: majiayu000 <1835304752@qq.com>
majiayu000
requested review from
andreynering and
raphamorim
and removed request for
a team
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #258
Changes
MakeFramesfunction to apply styling (padding, window bar, margins, border radius) to frame output🤖 Generated with Claude Code