ci: run code-pushup collect and upload in CI workflow#208
Conversation
…sking in CI logs)
Tlacenka
left a comment
There was a problem hiding this comment.
Great work with a lot of potential! Checking ourselves with our own product 😁
Unfortunately, when I checked the artifacts of the PR pipeline, I was unable to find any ESLint errors regarding vitest ESLint plugins. From what I understood, you removed the temporarily removed rules in order to show the current state but somehow the test files were not scanned.
Yes, great catch, that was not intentional 😅 Not easy to fix either, but I found a way. Now they're in 🎉 |
Tlacenka
left a comment
There was a problem hiding this comment.
In the latest artifact, test errors correspond to what I have been fixing. Good job!

Closes #197
The configuration for the ESLint plugin turned out to be very complex when targetting the whole monorepo, which is why I had to do some complex scripting in
code-pushup.config.tsto get it working 😬 I'll consider some ways this can be simplified for similar setups (e.g. provide some Nx helpers).But anyway, it works! 🎉 After this is merged, all our CI runs will upload new report to the portal in staging 🙌
The
report.jsonandreport.mdfiles are also uploaded as an artifact to GitHub Actions (e.g. here).