refactor: replace console.log with info, warn and error, introduce shared mock setup#337
Merged
refactor: replace console.log with info, warn and error, introduce shared mock setup#337
Conversation
Tlacenka
requested review from
BioPhoton,
IKatsuba,
MishaSeredenkoPushBased and
matejchalk
github-actions
bot
added
🔬 testing
Tlacenka
force-pushed
the
console-methods-refactor
branch
from
64508e3 to
cbdd80b
Compare
matejchalk
reviewed
Nov 29, 2023
packages/core/src/lib/implementation/persist.integration.test.ts
Outdated
Show resolved
Hide resolved
Tlacenka
force-pushed
the
console-methods-refactor
branch
from
cbdd80b to
14299ac
Compare
Collaborator
|
🔥 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #277
In this PR, I go through all packages and replace all occurrences of
console.logwithconsole.info,console.warnorconsole.error.Additionally, I set up all
vitestconfiguration files for both unit and integration tests to use console mocks.multi-progress-barschanges the behaviour ofconsolesee here. Currently, none of the utils integration tests use a console so until I get to that package refactor, I simply did not set up console mocks for integration tests there. But we may have to create a special type of a test file for such cases. What do you think?