refactor: update commitlint and remove unnecessary changelog angular dependency#858
Merged
refactor: update commitlint and remove unnecessary changelog angular dependency#858
Conversation
Contributor
Code PushUp🤨 Code PushUp report has both improvements and regressions – compared target commit 777c86b with source commit b472450. 🕵️ See full comparison in Code PushUp portal 🔍 🏷️ Categories👍 1 group improved, 👎 1 group regressed, 👍 2 audits improved, 👎 3 audits regressed, 13 audits changed without impacting score🗃️ Groups
18 other groups are unchanged. 🛡️ Audits
495 other audits are unchanged. |
matejchalk
reviewed
Oct 18, 2024
Collaborator
matejchalk
left a comment
There was a problem hiding this comment.
The conventional-changelog-angular package is still installed via indirect dependencies. However, there is no @angular-devkit/build-angular installed.
It's not installed on main either, so I'm not sure what the point of this issue was 😅
But nice to have Commitlint updated and config converted to ESM.
925005c to
5858cc8
Compare
…dependency closes #776 Signed-off-by: Vojtech Masek <vojtech@flowup.cz>
5858cc8 to
ed0f467
Compare
matejchalk
approved these changes
Oct 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


closes #776