Conversation
no ref Some legacy sites incorrectly have object shaped shared views. This restores the previous fallback to [].
no ref - Added transistor labs flag to cardConfig via useFeatureFlag - Set visibilitySettings to 'none' to hide visibility panel in email context - Bumped @tryghost/koenig-lexical to 1.7.27
ref https://linear.app/ghost/issue/NY-1154/ - existing preview substitution was bolted-on to visibility gating, which was inappropriate; it is now its own step The intent of this change is to provide a pattern for subtituting content in the Preview pane in Admin > Post Editor. In this case, we substitute a user-specific iframe with a placeholder rather than using a real user's uuid and display a real user's content.
## Summary - migrate the portal donations browser coverage into top-level e2e as portal-support.test.ts - add the donation flow and page-object support needed to keep the new tests readable - remove the old ghost/core/test/e2e-browser/portal/donations.spec.js coverage ## Testing - cd e2e && yarn eslint helpers/pages/public/public-page.ts helpers/pages/stripe/fake-checkout-page.ts helpers/pages/portal/index.ts helpers/pages/portal/support-success-page.ts helpers/pages/portal/notification-page.ts helpers/playwright/flows/donations.ts helpers/playwright/flows/index.ts helpers/services/settings/settings-service.ts helpers/services/stripe/fake-stripe-server.ts tests/public/portal-support.test.ts - cd e2e && yarn test:types - cd /Users/slars/dev/ghost/Ghost/e2e && GHOST_E2E_SKIP_BUILD=1 yarn test tests/public/portal-support.test.ts
ref https://linear.app/ghost/issue/PLA-9/ - adds fake Stripe support for updating and deleting subscriptions in top-level e2e - adds a focused smoke test that exercises Ghost-driven subscription price switching against the fake Stripe server - extends the Portal signup page object so the test can select a specific paid tier deterministically
ref 05e0954 - some card styles were still part of the newsletter styles.hbs not the card-styles.hbs file - wired up placeholder uuid for test emails
## Summary - Migrated the subscription access / publish flow test from `ghost/core/test/e2e-browser/` to `e2e/tests/admin/posts/publish-flow.test.ts` - Added `PublishFlow` page object to `PostEditorPage` for publish flow locators - Deleted the old `ghost/core/test/e2e-browser/admin/site-settings.spec.js`
no-issue Several callers (handle-image-sizes middleware, image-size service) call exists() with a single path argument rather than separate fileName + targetDir. S3Storage required both, causing path.posix.join to throw on undefined. Made targetDir optional in exists() and delete(), falling back to using fileName directly as the relative path — matching LocalStorageBase's behavior.
ref https://linear.app/ghost/issue/PLA-9/ ref #26927 - migrated existing tier/subscription upgrade tests to /e2e/
no ref Further iteration on welcome email customization. This PR enriches the welcome email preview with realistic content (heading, paragraphs, divider, image, button) so all design customization options have visible effect. Fixes accessibility issues in the sidebar, wires up heading font/weight and image corners settings, and fixes scroll behavior to match the newsletter modal. note: there's some slight overlap with changes in #26926, so the last commit ([cb3d2fc](cb3d2fc)) drops some of the changes here (like the scroll fix) in favor of the changes in the other PR to make merging everything easier. But the PRs together cover everything listed above.
ref https://linear.app/ghost/issue/BER-3356 When members are filtered by fields like labels, tiers, subscription status, or plan interval, up to two relevant columns are now appended to the list so the filtered data is visible without opening each member. The members list is converted from div-based grid layout to a proper HTML table to support the variable column count.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )