Skip to content

docs: clarify that current_url() returns URL based on Config\App#5808

Merged
kenjis merged 1 commit intocodeigniter4:developfrom
kenjis:fix-current_url
Mar 20, 2022
Merged

docs: clarify that current_url() returns URL based on Config\App#5808
kenjis merged 1 commit intocodeigniter4:developfrom
kenjis:fix-current_url

Conversation

@kenjis
Copy link
Copy Markdown
Member

@kenjis kenjis commented Mar 18, 2022

Description
Fixes #5807

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the documentation Pull requests for documentation only label Mar 18, 2022
Copy link
Copy Markdown
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't wait to overhaul URIs in version 5. What a mess 😓

Good clarification.

@kenjis kenjis merged commit 2a1f23f into codeigniter4:develop Mar 20, 2022
@kenjis kenjis deleted the fix-current_url branch March 20, 2022 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Pull requests for documentation only

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: current_url() returning wrong value when different host

2 participants