Skip to content

refactor: remove unneeded code in IncomingRequest#7525

Merged
samsonasik merged 1 commit intocodeigniter4:developfrom
kenjis:refactor-IncomingRequest-getLocale
May 30, 2023
Merged

refactor: remove unneeded code in IncomingRequest#7525
samsonasik merged 1 commit intocodeigniter4:developfrom
kenjis:refactor-IncomingRequest-getLocale

Conversation

@kenjis
Copy link
Copy Markdown
Member

@kenjis kenjis commented May 26, 2023

Description
$this->locale is set in the detectLocale() method called in the constructor.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis
refactor: remove unneeded code
a4de3e7 
$this->locale is set in the detectLocale() method called in the constructor.
@kenjis kenjis added the refactor Pull requests that refactor code label May 26, 2023
@samsonasik samsonasik merged commit 167042a into codeigniter4:develop May 30, 2023
@samsonasik
Copy link
Copy Markdown
Member

samsonasik commented May 30, 2023

Thank you @kenjis

@kenjis kenjis deleted the refactor-IncomingRequest-getLocale branch June 1, 2023 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michalsn michalsn michalsn approved these changes

@samsonasik samsonasik samsonasik approved these changes

Assignees

No one assigned

Labels

refactor Pull requests that refactor code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kenjis @samsonasik @michalsn