Skip to content

fix: psalm error#1003

Merged
datamweb merged 1 commit intocodeigniter4:developfrom
datamweb:fix-psalm-error
Jan 20, 2024
Merged

fix: psalm error#1003
datamweb merged 1 commit intocodeigniter4:developfrom
datamweb:fix-psalm-error

Conversation

@datamweb
Copy link
Copy Markdown
Collaborator

@datamweb datamweb commented Jan 19, 2024

Description

Error: src/Models/UserIdentityModel.php:551:40: ParamNameMismatch: Argument 2 of CodeIgniter\Shield\Models\UserIdentityModel::update has wrong name $data, expecting $row as defined by CodeIgniter\Model::update (see https://psalm.dev/230)
Error: src/Models/UserIdentityModel.php:551:40: ParamNameMismatch: Argument 2 of CodeIgniter\Shield\Models\UserIdentityModel::update has wrong name $data, expecting $row as defined by CodeIgniter\BaseModel::update (see https://psalm.dev/[23](https://github.com/codeigniter4/shield/actions/runs/7579206531/job/20643033351?pr=1002#step:9:24)0)
Error: src/Models/UserModel.php:260:28: ParamNameMismatch: Argument 1 of CodeIgniter\Shield\Models\UserModel::insert has wrong name $data, expecting $row as defined by CodeIgniter\Model::insert (see https://psalm.dev/230)
Error: src/Models/UserModel.php:260:28: ParamNameMismatch: Argument 1 of CodeIgniter\Shield\Models\UserModel::insert has wrong name $data, expecting $row as defined by CodeIgniter\BaseModel::insert (see https://psalm.dev/230)
Error: src/Models/UserModel.php:283:40: ParamNameMismatch: Argument 2 of CodeIgniter\Shield\Models\UserModel::update has wrong name $data, expecting $row as defined by CodeIgniter\Model::update (see https://psalm.dev/230)
Error: src/Models/UserModel.php:283:40: ParamNameMismatch: Argument 2 of CodeIgniter\Shield\Models\UserModel::update has wrong name $data, expecting $row as defined by CodeIgniter\BaseModel::update (see https://psalm.dev/230)
Error: src/Models/UserModel.php:3[25](https://github.com/codeigniter4/shield/actions/runs/7579206531/job/20643033351?pr=1002#step:9:26):26: ParamNameMismatch: Argument 1 of CodeIgniter\Shield\Models\UserModel::save has wrong name $data, expecting $row as defined by CodeIgniter\BaseModel::save (see https://psalm.dev/230)

https://github.com/codeigniter4/shield/actions/runs/7579206530/job/20643032829?pr=1002

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@datamweb datamweb merged commit 7c8140d into codeigniter4:develop Jan 20, 2024
@datamweb datamweb deleted the fix-psalm-error branch January 20, 2024 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants