feat: customize name of Shield Tables

[datamweb]

No description provided.

[datamweb]

What has happened PHPStan! There is no error in local!

And PHPUNIT test !

[kenjis]

What has happened PHPStan! There is no error in local!

I also have no error on my local environment.
But config() returns object|null.
So null->authTables is "Trying to get property 'authTables' of non-object".

[kenjis]

@datamweb

And PHPUNIT test !

The test does not seem to pass on Windows from the beginning.

CLI::write() outputs PHP_EOL, but the test code uses LF as newline code.

[datamweb]

@kenjis , thanks for the explanation, it made sense.
But how can I fix error PHPStan?

[datamweb]

I thought it could be fixed.
I'm surprised, even when I tried to pass the check with @phpstan-ignore-line the error was still detected.

[kenjis]

Why?
PHP 8.0 and PHP 8.1

Error: Attempt to read property "tables" on null
 ------ ------------------------------------------- 
  Line   src/Config/Constants.php                   
 ------ ------------------------------------------- 
  10     Attempt to read property "tables" on null  
 ------ ------------------------------------------- 

[datamweb]

PHP 7.4:

Error: Trying to get property 'tables' of non-object
 ------ ----------------------------------------------- 
  Line   src/Config/Constants.php                       
 ------ ----------------------------------------------- 
  10     Trying to get property 'tables' of non-object  
 ------ -----------------------------------------------

[datamweb]

@kenjis , after many efforts, I finally found the solution.
But I don't know exactly where the main problem is, I think it's in the framework , please let me know if you understand something.

[kenjis]

@datamweb I don't know what's wrong with PHPStan.
To begin with, I cannot reproduce the error.

But why don't we remove the constant?
I think using global constant is not good practice especially in libraries.
Global constants are for a user app, and a library should not consume them.

Ion Auth also havs $table, but it does not use a constant.
https://github.com/benedmunds/CodeIgniter-Ion-Auth/blob/6ebcd542011dbc35045466acad0172d2b68ae051/Config/IonAuth.php#L49-L54

We can get the values with config('Auth')->tables.

I gave it a try. See #633

[datamweb]

But why don't we remove the constant?

The reason I used constant was to add this feature with minimal changes.(

) vs
()

Also, I think it is easier to read and review with this implementation. For example, look at PR commit, it's easier to suggest a change for SHIELD_TABLES['users'] or

    /**
     * Auth Table names
     */
    private array $tables;

    public function __construct(?Forge $forge = null)
    {
        parent::__construct($forge);

        /** @var Auth $authConfig */
        $authConfig   = config('Auth');
        $this->tables = $authConfig->tables;
    }
// and ...

In fact, I believe that using constant makes our codes shorter and more readable.
Also I was going to include a constant for the SHIELD_VERSION, which now I don't know where it fits with the no constant implementation.

Technically yes you are right, but we have an example of using constant in Bonfire2.

[kenjis]

I don't know we should use the constant or not.
But even if we use it, I would like to remove the include_once line and the constant file.

[kenjis]

If we add SHIELD_VERSION, we should add it as a class constant like CodeIgniter\CodeIgniter::CI_VERSION.
Class constants do not consume the global namespace.

[datamweb]

Okay, we will continue in your PR.

[kenjis]

Closed by #633