feat: HMAC SHA256 Authentication#795
Conversation
|
Thank you for sending this PR! You must GPG-sign your work, certifying that you either wrote the work or otherwise have the right to pass it on to an open-source project. |
|
And we don't use |
@kenjis My apologies, I thought I had that setup correctly. Since I obviously didn't, how do I retroactively sign what I have submitted? |
|
@kenjis I have rebased and signed my code. I appreciate your assistance on that. |
|
@tswagger Thank you! |
|
I am not sure how you would like me to address the final failed check. I intentionally mirrored the Authorize Tokens classes. I could create a shared trait or abstract parent class, but some of the differences, while subtle, are major enough to make that challenging. |
|
We will give it some consideration, so please leave it as it is. Adding Trait or abstract classes could make the design worse. |
|
That was my thought. I will leave it in your hands. Please let me know if you need anything else from me. |
Co-authored-by: John Paul E. Balandan, CPA <paulbalandan@gmail.com>
Co-authored-by: John Paul E. Balandan, CPA <paulbalandan@gmail.com>
Signed-off-by: tswagger <tim@renowne.com>
Signed-off-by: tswagger <tim@renowne.com>
Co-authored-by: kenjis <kenji.uui@gmail.com>
Co-authored-by: kenjis <kenji.uui@gmail.com>
Signed-off-by: tswagger <tim@renowne.com>
Signed-off-by: tswagger <tim@renowne.com>
Added AuthToken config as a separate config for Token/HMAC auth from JWT Updated test to reflect logging adjustment change. Signed-off-by: tswagger <tim@renowne.com>
Co-authored-by: kenjis <kenji.uui@gmail.com>
Signed-off-by: tswagger <tim@renowne.com>
Signed-off-by: tswagger <tim@renowne.com>
Signed-off-by: tswagger <tim@renowne.com>
Co-authored-by: Pooya Parsa <pooya_parsa_dadashi@yahoo.com>
Co-authored-by: Pooya Parsa <pooya_parsa_dadashi@yahoo.com>
Signed-off-by: tswagger <tim@renowne.com>
Signed-off-by: tswagger <tim@renowne.com>
Signed-off-by: tswagger <tim@renowne.com>
Signed-off-by: tswagger <tim@renowne.com>
Signed-off-by: tswagger <tim@renowne.com>
Signed-off-by: tswagger <tim@renowne.com>
Signed-off-by: tswagger <tim@renowne.com>
cedf26e to
a1b64db
Compare
Signed-off-by: tswagger <tim@renowne.com>
|
Cannot reproduce the PHPStan errors. https://github.com/codeigniter4/shield/actions/runs/6223741069/job/16907463318?pr=795 |
|
@tswagger Thank you! |
|
Oh, my dependencies were old. Fixed by #840 |
Adding HMAC-SHA256 as an authenticator. This method has a slight security advantage to a standard token authentication by signing the request with a shared secret.
Usage and coding mirrors closely the established Access Token Authentication classes and methods.
References: