Skip to content

Volmeshartist bug#1158

Merged
tomvanmele merged 2 commits intomainfrom
volmeshartist_bug
Jun 14, 2023
Merged

Volmeshartist bug#1158
tomvanmele merged 2 commits intomainfrom
volmeshartist_bug

Conversation

@gonzalocasas
Copy link
Copy Markdown
Member

@gonzalocasas gonzalocasas commented Jun 13, 2023

All 3 volmesh artists seem to be affected by the same bug.

What type of change is this?

  • Bug fix in a backwards-compatible manner.
  • New feature in a backwards-compatible manner.
  • Breaking change: bug fix or new feature that involve incompatible API changes.
  • Other (e.g. doc update, configuration, etc)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I added a line to the CHANGELOG.md file in the Unreleased section under the most fitting heading (e.g. Added, Changed, Removed).
  • I ran all tests on my computer and it's all green (i.e. invoke test).
  • I ran lint on my computer and there are no errors (i.e. invoke lint).
  • I added new functions/classes and made them available on a second-level import, e.g. compas.datastructures.Mesh.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added necessary documentation (if appropriate)

@gonzalocasas gonzalocasas requested a review from tomvanmele June 13, 2023 21:16
Copy link
Copy Markdown
Member

@tomvanmele tomvanmele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tomvanmele tomvanmele merged commit c8dcf25 into main Jun 14, 2023
@tomvanmele tomvanmele deleted the volmeshartist_bug branch June 14, 2023 16:31
@gonzalocasas gonzalocasas mentioned this pull request Sep 10, 2023
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants