Skip to content

feat: replaced delete and uninstall command api calls #247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
harshithad0703 merged 1 commit into from
Jun 7, 2024
Merged

feat: replaced delete and uninstall command api calls #247

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/commands/app/delete.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ export default class Delete extends AppCLIBaseCommand {

if (!this.flags["app-uid"]) {
app = await getApp(this.flags, this.sharedConfig.org, {
managementSdk: this.managementAppSdk,
marketplaceSdk: this.marketplaceAppSdk,
log: this.log,
});
this.flags["app-uid"] = app?.uid;
Expand All @@ -49,7 +49,7 @@ export default class Delete extends AppCLIBaseCommand {

if (userConfirmation) {
await deleteApp(this.flags, this.sharedConfig.org, {
managementSdk: this.managementAppSdk,
marketplaceSdk: this.marketplaceAppSdk,
log: this.log,
});
this.log(
Expand Down
4 changes: 2 additions & 2 deletions src/commands/app/install.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,12 +55,12 @@ export default class Install extends AppCLIBaseCommand {
// fetch app details
if (!this.flags["app-uid"]) {
app = await getApp(this.flags, this.sharedConfig.org, {
managementSdk: this.managementAppSdk,
marketplaceSdk: this.marketplaceAppSdk,
log: this.log,
});
} else {
app = await fetchApp(this.flags, this.sharedConfig.org, {
managementSdk: this.managementAppSdk,
marketplaceSdk: this.marketplaceAppSdk,
log: this.log,
});
}
Expand Down
4 changes: 2 additions & 2 deletions src/commands/app/reinstall.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,12 +50,12 @@ export default class Reinstall extends AppCLIBaseCommand {

if (!this.flags["app-uid"]) {
app = await getApp(this.flags, this.sharedConfig.org, {
managementSdk: this.managementAppSdk,
marketplaceSdk: this.marketplaceAppSdk,
log: this.log,
});
} else {
app = await fetchApp(this.flags, this.sharedConfig.org, {
managementSdk: this.managementAppSdk,
marketplaceSdk: this.marketplaceAppSdk,
log: this.log,
});
}
Expand Down
4 changes: 2 additions & 2 deletions src/commands/app/uninstall.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,9 @@ export default class Uninstall extends AppCLIBaseCommand {

// fetch app details
if (!this.flags['app-uid']) {
app = await getInstalledApps(this.flags, this.sharedConfig.org, {managementSdk: this.managementAppSdk, log: this.log})
app = await getInstalledApps(this.flags, this.sharedConfig.org, {marketplaceSdk: this.marketplaceAppSdk, log: this.log})
} else {
app = await fetchApp(this.flags, this.sharedConfig.org, {managementSdk: this.managementAppSdk, log: this.log})
app = await fetchApp(this.flags, this.sharedConfig.org, {marketplaceSdk: this.marketplaceAppSdk, log: this.log})
}

this.flags['app-uid'] = app?.uid;
Expand Down
8 changes: 4 additions & 4 deletions src/util/common-utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,11 +113,11 @@ function fetchAppInstallations(
});
}

function deleteApp(flags: FlagInput, orgUid: string, options: CommonOptions) {
const { managementSdk } = options;
function deleteApp(flags: FlagInput, orgUid: string, options: MarketPlaceOptions) {
const { marketplaceSdk } = options;
const app: any = flags["app-uid"];
return managementSdk
.organization(orgUid)
return marketplaceSdk
.marketplace(orgUid)
.app(app as string)
.delete();
}
Expand Down