fix(types): a few updates to typing#111
Merged
cpburnz merged 1 commit intocpburnz:masterfrom Mar 10, 2026
Merged
Conversation
cpburnz
reviewed
Mar 7, 2026
henryiii
force-pushed
the
henryiii/fix/types1
branch
from
e242db7 to
d06f56a
Compare
Signed-off-by: Henry Schreiner <henryfs@princeton.edu>
henryiii
force-pushed
the
henryiii/fix/types1
branch
from
d06f56a to
0f25585
Compare
Contributor
Author
|
FYI, all tests are broken on |
Owner
|
Thanks, yeah I committed some breaking tests for #93. I should have committed to a separate branch rather than master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just a few quick updates from running mypy.
The biggest one isEdit: There are several places that make assumptions about this Sequence supporting + and +=, so leaving that off for now. This is now purely typing.+currently assumes you can add theSequence's, which is not true for arbitrarySequence.