Adapt to change in yojson and cmdliner#6
Open
FardaleM wants to merge 4 commits intocyborgize:masterfrom
Open
Conversation
Contributor
|
Thanks! I think some constraints on package versions must be added. |
Author
|
I am not sure which constraint should be added. I tested it with cmdliner 1.3 and 2.1 both works fine. Same for yojson, I tested it with yojson 2.2.2 and 3.0.0 and both work also. If you want I can put this as lower bound. |
Khady
reviewed
Mar 25, 2026
| (targets config_j.ml config_j.mli) | ||
| (deps config.atd) | ||
| (action (run atdgen -j -j-std %{deps}))) | ||
| (action (run atdgen -j %{deps}))) |
Contributor
There was a problem hiding this comment.
is it going to change the behavior if installed in a switch that has atd2 only?
Author
There was a problem hiding this comment.
Good catch, I can revert this change or put a lower bound. What would be the best?
There was a problem hiding this comment.
just keep the option, it is no-op in newer atdgen
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adapt code to work with yojson 3.* and cmdliner 2.*.
Remove use of deprecated option with atdgen.