Merged
Conversation
And use it in `test_fft.py`
And rudimentary support for `2*(m-1)` size rules
honno
commented
Oct 16, 2023
array_api_tests/pytest_helpers.py
Outdated
| ), f"{out_repr} not as expected {f_func}\n{out_repr}={out!r}\n{expected=}" | ||
|
|
||
|
|
||
| def _make_wrapped_assert_helper(assert_helper: Callable) -> Callable: |
Member
Author
There was a problem hiding this comment.
TODO: remove this now I've manually added __tracebackhide__
Member
|
@honno how far off is this from getting merged you think? |
Member
Author
I'll just merge it, the tests are very thorough now (except there's no tests shift/freq which I can do in a follow-up PR). Some hacks and code I'd like to remove/refactor but good to just get this in—it doesn't seem to break anything! Current failures are the same on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP PR for FFT tests. Needs some refactoring and some more shape asserts. freq/shift tests can come in a seperate PR.
TODO: