feat: add count_nonzero to specification#803
Merged
kgryte merged 4 commits intodata-apis:mainfrom Dec 12, 2024
Merged
Conversation
kgryte
added
the
Needs Changes
kgryte
added
Needs Review
Contributor
Author
|
As this PR has not received any objections since May 1 and has previously been discussed in workgroup meetings, I'll go ahead and merge so that we can begin test suite and compat work. Any further changes can be addressed in follow-up PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR
count_nonzerofor counting the number of "non-zero" values #794 by adding support for counting the number of non-zero values to the specification.max,mean,sum, etc) in supporting one or more axes over which to perform the reduction and in supportingkeepdimsto ensure the returned result is broadcast compatible.followsUpdate: based on discussions during the May 2, 2024 workgroup meeting, consensus was to allow 0d input arrays. The proposed specification has been updated accordingly.nonzeros(ref: Add specifications for functions for searching arrays #23 (comment)) in disallowing zero-dimensional input arrays. Note, however, that the statistical function APIs do not contain any explicit guidance regarding minimum rank.nonzerosby moving the notes to a dedicated notes section (i.e., below the "fold").