Conversation
✅ Deploy Preview for developertools-tech ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
@TechSpiritSS I'll look into that issue and get back to you, we can't merge as is unfortunately. |
|
:') well, that's fine, if you know the reason for the bug do let me know as well. |
dlford
left a comment
dlford
left a comment
There was a problem hiding this comment.
@TechSpiritSS Awesome! Code looks solid, just a few UI tweaks.
Also, I think it would add a lot of utility if we could add a field for the output separator so you could change a newline separated list to comma separated, etc. (This would also require a sort option of "keep order").
If that's too much to ask I can create a new issue for it.
|
I think it's better to change that into new issue as I might not be able to commit those changes as I am travelling for next two days. |
No worries, just the UI fixes then please |
|
@TechSpiritSS are you still wanting to work on this? |
|
Yes, I'll work on this, got some college stuff to deal with this week. |
|
No worries, thank you! |
2 participants
Type of Pull Request
Related Issue #s or links (if any):
#21
Description of Changes
Everything is working great and tested except for one bug.
User is required to click sort twice in case of New Line separator to get the desired result. I'm not sure why this is happening but I wasn't able to resolve this bug.